Issue 601069: Fix the TranslateManager and unit-tests....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 601069: Fix the TranslateManager and unit-tests.... (Closed)

Created:
10 years, 10 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
wtc, kuan

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix the TranslateManager and unit-tests. There was a bug that was initialy turning on translate all the time. When fixed it made the unit-tests fail, revealing another bug. The test was calling a virtual method in its constructor, which was bad and not turning on translate for the tests. BUG=None TEST=UI tests, browser tests, unit-tests should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38995

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -8 lines)			Patch
M	chrome/browser/translate/translate_manager.h	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/translate/translate_manager.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/translate/translate_manager_unittest.cc	View	1	2 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

On 2010/02/13 01:22:27, wtc wrote:
> LGTM.

LGTM.

Expand Messages | Collapse Messages