Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: chrome/browser/renderer_host/render_widget_host.cc

Issue 6010004: Refactor RenderWidgetHost::set_paint_observer() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove helper classes per review Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/render_widget_host.cc
diff --git a/chrome/browser/renderer_host/render_widget_host.cc b/chrome/browser/renderer_host/render_widget_host.cc
index 7a7a5d6bdada992fd57f76076500202951255a84..68484835e5cb17c8ff3193d3c987e7f4b6368073 100644
--- a/chrome/browser/renderer_host/render_widget_host.cc
+++ b/chrome/browser/renderer_host/render_widget_host.cc
@@ -15,7 +15,6 @@
#include "chrome/browser/renderer_host/backing_store_manager.h"
#include "chrome/browser/renderer_host/render_process_host.h"
#include "chrome/browser/renderer_host/render_widget_helper.h"
-#include "chrome/browser/renderer_host/render_widget_host_painting_observer.h"
#include "chrome/browser/renderer_host/render_widget_host_view.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/result_codes.h"
@@ -74,7 +73,6 @@ RenderWidgetHost::RenderWidgetHost(RenderProcessHost* process,
renderer_accessible_(false),
view_(NULL),
process_(process),
- painting_observer_(NULL),
routing_id_(routing_id),
is_loading_(false),
is_hidden_(false),
@@ -798,17 +796,22 @@ void RenderWidgetHost::OnMsgRequestMove(const gfx::Rect& pos) {
}
void RenderWidgetHost::OnMsgPaintAtSizeAck(int tag, const gfx::Size& size) {
- if (painting_observer_) {
- painting_observer_->WidgetDidReceivePaintAtSizeAck(this, tag, size);
- }
+ PaintAtSizeAckDetails details = {tag, size};
+ gfx::Size size_details = size;
+ NotificationService::current()->Notify(
+ NotificationType::RENDER_WIDGET_HOST_DID_RECEIVE_PAINT_AT_SIZE_ACK,
+ Source<RenderWidgetHost>(this),
+ Details<PaintAtSizeAckDetails>(&details));
}
void RenderWidgetHost::OnMsgUpdateRect(
const ViewHostMsg_UpdateRect_Params& params) {
TimeTicks paint_start = TimeTicks::Now();
- if (paint_observer_.get())
- paint_observer_->RenderWidgetHostWillPaint(this);
+ NotificationService::current()->Notify(
+ NotificationType::RENDER_WIDGET_HOST_WILL_PAINT,
+ Source<RenderWidgetHost>(this),
+ NotificationService::NoDetails());
// Update our knowledge of the RenderWidget's size.
current_size_ = params.view_size;
@@ -900,8 +903,10 @@ void RenderWidgetHost::OnMsgUpdateRect(
}
}
- if (paint_observer_.get())
- paint_observer_->RenderWidgetHostDidPaint(this);
+ NotificationService::current()->Notify(
+ NotificationType::RENDER_WIDGET_HOST_DID_PAINT,
+ Source<RenderWidgetHost>(this),
+ NotificationService::NoDetails());
// If we got a resize ack, then perhaps we have another resize to send?
if (is_resize_ack && view_) {
@@ -910,8 +915,10 @@ void RenderWidgetHost::OnMsgUpdateRect(
WasResized();
}
- if (painting_observer_)
- painting_observer_->WidgetDidUpdateBackingStore(this);
+ NotificationService::current()->Notify(
+ NotificationType::RENDER_WIDGET_HOST_DID_UPDATE_BACKING_STORE,
+ Source<RenderWidgetHost>(this),
+ NotificationService::NoDetails());
// Log the time delta for processing a paint message.
TimeDelta delta = TimeTicks::Now() - paint_start;

Powered by Google App Engine
This is Rietveld 408576698