Refactor RenderWidgetHost::set_paint_observer()

chrome/browser/instant/instant_loader.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/instant/instant_loader.h"
 
 #include <algorithm>
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 15 matching lines @@
 #include "chrome/browser/tab_contents/navigation_controller.h"
 #include "chrome/browser/tab_contents/navigation_entry.h"
 #include "chrome/browser/tab_contents/tab_contents.h"
 #include "chrome/browser/tab_contents/tab_contents_delegate.h"
 #include "chrome/browser/tab_contents/tab_contents_view.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/notification_details.h"
 #include "chrome/common/notification_observer.h"
 #include "chrome/common/notification_registrar.h"
+#include "chrome/common/notification_service.h"
 #include "chrome/common/notification_source.h"
 #include "chrome/common/notification_type.h"
 #include "chrome/common/page_transition_types.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/renderer_preferences.h"
 #include "gfx/codec/png_codec.h"
 #include "ipc/ipc_message.h"
 #include "net/http/http_util.h"
 
 namespace {
@@ skipping 80 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(FrameLoadObserver);
 };
 
 // PaintObserver implementation. When the RenderWidgetHost paints itself this
 // notifies the TabContentsDelegateImpl which ultimately notifies InstantLoader
 // and shows the preview.
 // The ownership of this class is tricky. It's created and
 // tracked by TabContentsDelegateImpl, but owned by RenderWidgetHost. When
 // deleted this notifies the TabContentsDelegateImpl so that it can clean
 // up appropriately.
-class InstantLoader::PaintObserverImpl
-    : public RenderWidgetHost::PaintObserver {
+class InstantLoader::PaintObserverImpl : public NotificationObserver {
  public:
   PaintObserverImpl(TabContentsDelegateImpl* delegate,
-                    RenderWidgetHost* rwh)
-      : delegate_(delegate),
-        rwh_(rwh) {
-    rwh_->set_paint_observer(this);
+                    RenderWidgetHost* render_widget_host)
+      : delegate_(delegate) {
+    registrar_.Add(this, NotificationType::RENDER_WIDGET_HOST_DID_PAINT,
+        Source<RenderWidgetHost>(render_widget_host));
+    registrar_.Add(this, NotificationType::RENDER_WIDGET_HOST_DESTROYED,
+        Source<RenderWidgetHost>(render_widget_host));
   }
 
   ~PaintObserverImpl();
 
-  // Deletes this object by resetting the PaintObserver on the RenderWidgetHost.
-  void Destroy() {
-    rwh_->set_paint_observer(NULL);
-  }
-
-  virtual void RenderWidgetHostWillPaint(RenderWidgetHost* rwh) {}
-
-  virtual void RenderWidgetHostDidPaint(RenderWidgetHost* rwh);
+  void Observe(NotificationType type,
+      const NotificationSource& source,

[brettw, 2011/01/03 19:48:30]

Indent these two args to the first one.

[DaveMoore, 2011/01/07 19:04:05]

N/A
On 2011/01/03 19:48:30, brettw wrote:

+      const NotificationDetails& details);
 
  private:
   TabContentsDelegateImpl* delegate_;
-  RenderWidgetHost* rwh_;
+  NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(PaintObserverImpl);
 };
 
 class InstantLoader::TabContentsDelegateImpl : public TabContentsDelegate {
  public:
   explicit TabContentsDelegateImpl(InstantLoader* loader)
       : loader_(loader),
         paint_observer_(NULL),
         waiting_for_new_page_(true),
@@ skipping 238 matching lines @@
   void CommitFromMouseReleaseIfNecessary() {
     bool was_down = is_mouse_down_from_activate_;
     is_mouse_down_from_activate_ = false;
     if (was_down && loader_->ShouldCommitInstantOnMouseUp())
       loader_->CommitInstantLoader();
   }
 
   // If the PaintObserver is non-null Destroy is invoked on it.
   void DestroyPaintObserver() {
     if (paint_observer_) {
-      paint_observer_->Destroy();
-      // Destroy should result in invoking PaintObserverDestroyed and NULLing
+      delete paint_observer_;
+      // delete should result in invoking PaintObserverDestroyed and NULLing
       // out paint_observer_.
       DCHECK(!paint_observer_);
     }
   }
 
   InstantLoader* loader_;
 
   // Used to listen for paint so that we know when to show the preview. See
   // comment in NavigationStateChanged for details on this.
   // Ownership of this is tricky, see comment above PaintObserverImpl class.
@@ skipping 15 matching lines @@
   // True if the user typed in the search box before the page loaded.
   bool user_typed_before_load_;
 
   DISALLOW_COPY_AND_ASSIGN(TabContentsDelegateImpl);
 };
 
 InstantLoader::PaintObserverImpl::~PaintObserverImpl() {
   delegate_->PaintObserverDestroyed(this);
 }
 
-void InstantLoader::PaintObserverImpl::RenderWidgetHostDidPaint(
-    RenderWidgetHost* rwh) {
-  TabContentsDelegateImpl* delegate = delegate_;
-  // Set the paint observer to NULL, which deletes us. Showing the preview may
-  // reset the paint observer, and delete us. By resetting the delegate first we
-  // know we've been deleted and can deal correctly.
-  rwh->set_paint_observer(NULL);
-  // WARNING: we've been deleted.
-  if (delegate)
-    delegate->PreviewPainted();
+void InstantLoader::PaintObserverImpl::Observe(NotificationType type,

[brettw, 2011/01/03 19:48:30]

Move this arg to the next line, indented 4 spaces.

[DaveMoore, 2011/01/07 19:04:05]

N/A
On 2011/01/03 19:48:30, brettw wrote:

+    const NotificationSource& source,
+    const NotificationDetails& details) {
+  if (type == NotificationType::RENDER_WIDGET_HOST_DID_PAINT) {
+    TabContentsDelegateImpl* delegate = delegate_;
+    // Delete outselves. Showing the preview may reload content. By resetting
+    // the observer first we know we've been deleted and can deal correctly.
+    delete this;
+    // WARNING: we've been deleted.
+    if (delegate)
+      delegate->PreviewPainted();
+  } else if (type == NotificationType::RENDER_WIDGET_HOST_DESTROYED) {
+    delete this;
+  }
 }
 
 InstantLoader::InstantLoader(InstantLoaderDelegate* delegate, TemplateURLID id)
     : delegate_(delegate),
       template_url_id_(id),
       ready_(false),
       last_transition_type_(PageTransition::LINK) {
   preview_tab_contents_delegate_.reset(new TabContentsDelegateImpl(this));
 }
 
@@ skipping 146 matching lines @@
           user_text_, type == INSTANT_COMMIT_PRESSED_ENTER);
   }
   omnibox_bounds_ = gfx::Rect();
   last_omnibox_bounds_ = gfx::Rect();
   url_ = GURL();
   user_text_.clear();
   complete_suggested_text_.clear();
   if (preview_contents_.get()) {
     if (type != INSTANT_COMMIT_DESTROY)
       preview_tab_contents_delegate_->CommitHistory();
-    // Destroy the paint observer.
-    // RenderWidgetHostView may be null during shutdown.
     if (preview_contents_->tab_contents()->GetRenderWidgetHostView()) {
-      preview_contents_->tab_contents()->GetRenderWidgetHostView()->
-          GetRenderWidgetHost()->set_paint_observer(NULL);
 #if defined(OS_MACOSX)
       preview_contents_->tab_contents()->GetRenderWidgetHostView()->
           SetTakesFocusOnlyOnMouseDown(false);
       registrar_.Remove(
           this,
           NotificationType::RENDER_VIEW_HOST_CHANGED,
           Source<NavigationController>(&preview_contents_->controller()));
 #endif
     }
     preview_contents_->set_delegate(NULL);
@@ skipping 168 matching lines @@
       Source<NavigationController>(&preview_contents_->controller()));
 #endif
 
   registrar_.Add(
       this,
       NotificationType::NAV_ENTRY_COMMITTED,
       Source<NavigationController>(&preview_contents_->controller()));
 
   preview_contents_->tab_contents()->ShowContents();
 }