Issue 60084: A quick fix for Issue 9596....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60084: A quick fix for Issue 9596.... (Closed)

Created:
11 years, 8 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A quick fix for Issue 9596. This issue is caused by my bonehead mistake in r4300: I misunderstand the behavior of Vista when we call the SetWindowsText() function. It actually cancels an ongoing composition. So, changing this behavior caused this regression. To fix this issue, this change cancels an ongoing composition instead of completing it. As far as I tested on my XP PC, this fix works also on XP. BUG=9596 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13241

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/autocomplete/autocomplete_edit_view_win.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages