Issue 60070: Fix linking with gold by cleaning up lib dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60070: Fix linking with gold by cleaning up lib dependencies. (Closed)

Created:
11 years, 8 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
agl, sgk

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix linking with gold by cleaning up lib dependencies. - Remove pangoft2, we don't use it anywhere. - Add gdk, fontconfig and freetype2 as dependencies of skia. Gdk is used in platform_canvas_linux. - X11, Xrender and Xext are used by the IPC system, so everything that depends on common, needs to link in those libs. By moving the link_settings line into the libcommon.a target, all projects inherit these.

Patch Set 1 #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -12 lines)			Patch
M	build/linux/system.gyp	View	1 chunk	+31 lines, -3 lines	0 comments	Download
M	chrome/chrome.gyp	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	skia/skia.gyp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	webkit/webkit.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages