Issue 60069: FFmpeg video decoder glue code...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60069: FFmpeg video decoder glue code... (Closed)

Created:
11 years, 8 months ago by Alpha Left Google

Modified:
9 years, 6 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews_googlegroups.com, ralphl, fbarchard, awong

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

FFmpeg video decoder glue code Implementation of FFmpeg to perform video decoding. Also added hooks to insert this FFmpeg video decoder filter. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13056

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+180 lines, -12 lines)			Patch
M	chrome/renderer/webmediaplayer_delegate_impl.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	media/base/buffers.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	media/filters/ffmpeg_video_decoder.h	View	1	2 chunks	+46 lines, -1 line	0 comments	Download
M	media/filters/ffmpeg_video_decoder.cc	View	1	1 chunk	+129 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

11 years, 8 months ago (2009-04-02 23:45:00 UTC) #2

LGTM

just some nits with comments and periods

http://codereview.chromium.org/60069/diff/1/2
File media/filters/ffmpeg_video_decoder.cc (right):

http://codereview.chromium.org/60069/diff/1/2#newcode51
Line 51: // Check for end of stream
period at end of comment

http://codereview.chromium.org/60069/diff/1/3
File media/filters/ffmpeg_video_decoder.h (right):

http://codereview.chromium.org/60069/diff/1/3#newcode72
Line 72: // A priority queue of presentation TimeTuples
period at end of comment

Expand Messages | Collapse Messages