Show OOM notification bar in all tabs sharing same render process

Show OOM notification bar in all tabs sharing same render process. This is the Chromium's part of the change.

When out-of-memory occurs in one of the pages sharing same render process synchronous IPC message will be sent to the browser to give it a chance to show notification bar for all tabs sharing that render process. The renderer will crash immediately after sending the message (see corresponding WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=52447).

BUG=40521
TEST=None

[yurys, 2010-12-23 09:49:37]

WebKit changes can be found at http://codereview.appspot.com/3797043/

[antonm, 2010-12-23 17:17:45]

I cannot properly review this patch even though it lgtm.

http://codereview.chromium.org/6006006/diff/6001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/tab_contents.h (right):

http://codereview.chromium.org/6006006/diff/6001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/tab_contents.h:1353: bool
renderer_ran_out_of_memory_;
nit: it looks like you should unify---either render or renderer.

[yurys, 2011-01-18 13:14:16]

Darin, Dimitri are you fine with this approach?

http://codereview.chromium.org/6006006/diff/6001/chrome/browser/tab_contents/...
File chrome/browser/tab_contents/tab_contents.h (right):

http://codereview.chromium.org/6006006/diff/6001/chrome/browser/tab_contents/...
chrome/browser/tab_contents/tab_contents.h:1353: bool
renderer_ran_out_of_memory_;
On 2010/12/23 17:17:45, antonm wrote:
> nit: it looks like you should unify---either render or renderer.

Done.

[darin (slow to review), 2011-01-19 16:53:50]

http://codereview.chromium.org/6006006/diff/15001/chrome/common/render_messag...
File chrome/common/render_messages_internal.h (right):

http://codereview.chromium.org/6006006/diff/15001/chrome/common/render_messag...
chrome/common/render_messages_internal.h:1852:
IPC_SYNC_MESSAGE_CONTROL0_0(ViewHostMsg_RenderProcessOutOfJSMemory)
Sync messages sent from renderer to browser should not be handled on the
browser's main thread as that can lead to a dead lock.  the browser main thread
can be blocked on a plugin process, which can be blocked on the renderer, which
is sending the sync IPC.

I think you need to install an IPC::MessageFilter to run on the IO thread that
can intercept this message, reply to it, and then PostTask over to the browser
UI thread if that is where you ultimately need to handle this IPC.

[yurys, 2011-02-01 14:00:31]

On 2011/01/19 16:53:50, darin wrote:
>
http://codereview.chromium.org/6006006/diff/15001/chrome/common/render_messag...
> File chrome/common/render_messages_internal.h (right):
> 
>
http://codereview.chromium.org/6006006/diff/15001/chrome/common/render_messag...
> chrome/common/render_messages_internal.h:1852:
> IPC_SYNC_MESSAGE_CONTROL0_0(ViewHostMsg_RenderProcessOutOfJSMemory)
> Sync messages sent from renderer to browser should not be handled on the
> browser's main thread as that can lead to a dead lock.  the browser main
thread
> can be blocked on a plugin process, which can be blocked on the renderer,
which
> is sending the sync IPC.
> 
> I think you need to install an IPC::MessageFilter to run on the IO thread that
> can intercept this message, reply to it, and then PostTask over to the browser
> UI thread if that is where you ultimately need to handle this IPC.

Done. I introduced OutOfMemoryMessageFilter which sends response to the sync
message on the IO thread and notifies corresponding tabs later on the UI thread.

[yurys, 2011-02-01 14:00:37]

http://codereview.chromium.org/6006006/diff/21001/chrome/browser/renderer_hos...
File chrome/browser/renderer_host/out_of_memory_message_filter.cc (right):

http://codereview.chromium.org/6006006/diff/21001/chrome/browser/renderer_hos...
chrome/browser/renderer_host/out_of_memory_message_filter.cc:49:
const_cast<IPC::Channel::Listener*>(listener)->OnMessageReceived(
I'd love to avoid const_cast here but I don't see another way to enumerate all
render views sharing the same render process here. Alternatively, we could use
NotificationService to notify corresponding tabs. I'm open to suggestions.