Issue 6006: Faster sort....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6006: Faster sort.... (Closed)

Created:
12 years, 2 months ago by olehougaard

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Faster sort. Using insertion sort below a certain threshold to give faster sorting of arrays (esp. short ones). Committed: http://code.google.com/p/v8/source/detail?r=395

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
	M	src/array.js	View		2 chunks	+36 lines, -1 line	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

12 years, 2 months ago (2008-09-30 09:50:56 UTC) #2

There's a bit of odd code style and a possible +/-1.  Otherwise lgtm.

http://codereview.chromium.org/6006/diff/1/2
File src/array.js (right):

http://codereview.chromium.org/6006/diff/1/2#newcode673
Line 673: for(var i = from + 1; i < to; i++) {
There should be a space between 'for' and '('.

http://codereview.chromium.org/6006/diff/1/2#newcode689
Line 689: max = mid;
I'm not 100% sure but I think this should be max = mid - 1.

Expand Messages | Collapse Messages