Issue 6005016: Add -multifail to the Google Update "ap" value if --multi-install is present ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6005016: Add -multifail to the Google Update "ap" value if --multi-install is present ... (Closed)

Created:
9 years, 11 months ago by grt (UTC plus 2)

Modified:
9 years, 7 months ago

Reviewers:
robertshield

CC:
chromium-reviews, amit, tommi (sloooow) - chröme

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add -multifail to the Google Update "ap" value if --multi-install is present on the command line. BUG=61609 TEST=Run mini_installer.exe and notice that -multifail is added to the "ap" value in the ClientState key when --multi-install is on the command-line. The value is removed by setup.exe at the end of a successful install. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70638

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -18 lines)			Patch
	M	chrome/installer/mini_installer/mini_installer.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/installer/mini_installer/mini_installer.cc	View	1	10 chunks	+53 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertshield

LGTM http://codereview.chromium.org/6005016/diff/1/chrome/installer/mini_installer/mini_installer.cc File chrome/installer/mini_installer/mini_installer.cc (right): http://codereview.chromium.org/6005016/diff/1/chrome/installer/mini_installer/mini_installer.cc#newcode324 chrome/installer/mini_installer/mini_installer.cc:324: // We want -multifail to immediately precede -fail. ...

9 years, 11 months ago (2011-01-06 20:41:29 UTC) #2

grt (UTC plus 2)

9 years, 11 months ago (2011-01-06 20:44:09 UTC) #3

Thanks for the speed and eyes.

http://codereview.chromium.org/6005016/diff/1/chrome/installer/mini_installer...
File chrome/installer/mini_installer/mini_installer.cc (right):

http://codereview.chromium.org/6005016/diff/1/chrome/installer/mini_installer...
chrome/installer/mini_installer/mini_installer.cc:324: // We want -multifail to
immediately precede -fail.  Chop off the latter
On 2011/01/06 20:41:29, robertshield wrote:
> -fail -> -full

Nice catch.  Done.

Expand Messages | Collapse Messages