Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 6005015: Revert 70618 - First pass at adding http/backend cache events to the NetLog. ... (Closed)

Created:
9 years, 11 months ago by mmenke
Modified:
9 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, amit, arv (Not doing code reviews), pam+watch_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org
Visibility:
Public.

Description

Revert 70618 - First pass at adding http/backend cache events to the NetLog. Adds sources and events for ActiveCacheEntry and EntryImpl objects, as well as adding cache read/write events to HttpCacheTransactions. Most new read/write events are only logged when NetLog logging mode is set to log all events. Also, net-internals now merges begin and end events that have parameters, as long as only one of them has parameters. I think this increases readability, at the cost of making it a little more difficult to follow timings with just the "st" values. BUG=59382 TEST=none yet, other than updates to existing tests. Review URL: http://codereview.chromium.org/4067002 TBR=mmenke@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -613 lines) Patch
M chrome/browser/net/connection_tester.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/passive_log_collector.h View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/net/passive_log_collector.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/resources/net_internals/logviewpainter.js View 2 chunks +33 lines, -32 lines 0 comments Download
M chrome/browser/resources/net_internals/main.css View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/net_internals/sourceentry.js View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/service/net/service_url_request_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/plugin/plugin_test.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/metrics_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/test/test_server_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/capturing_net_log.h View 3 chunks +0 lines, -7 lines 0 comments Download
M net/base/capturing_net_log.cc View 4 chunks +2 lines, -14 lines 0 comments Download
M net/base/net_log.h View 2 chunks +0 lines, -9 lines 0 comments Download
M net/base/net_log.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M net/base/net_log_event_type_list.h View 1 chunk +5 lines, -68 lines 0 comments Download
M net/base/net_log_source_type_list.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/disk_cache/backend_impl.h View 4 chunks +3 lines, -11 lines 0 comments Download
M net/disk_cache/backend_impl.cc View 11 chunks +9 lines, -20 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 8 chunks +10 lines, -12 lines 0 comments Download
M net/disk_cache/disk_cache.h View 2 chunks +1 line, -3 lines 0 comments Download
M net/disk_cache/disk_cache_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/disk_cache/disk_cache_test_base.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/disk_cache/disk_cache_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/entry_impl.h View 4 chunks +0 lines, -18 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 12 chunks +9 lines, -156 lines 0 comments Download
M net/disk_cache/sparse_control.cc View 6 chunks +2 lines, -50 lines 0 comments Download
M net/disk_cache/stress_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_cache.h View 5 chunks +3 lines, -8 lines 0 comments Download
M net/http/http_cache.cc View 5 chunks +8 lines, -14 lines 0 comments Download
M net/http/http_cache_transaction.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_cache_transaction.cc View 15 chunks +9 lines, -51 lines 0 comments Download
M net/http/http_cache_unittest.cc View 21 chunks +27 lines, -45 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_test_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/crash_cache/crash_cache.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/tools/dump_cache/upgrade.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/view_cache_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_disk_cache.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
mmenke
9 years, 11 months ago (2011-01-06 17:34:24 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698