Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 6005014: Small change to stack checks in unoptimized code. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Small change to stack checks in unoptimized code. The stack checks include a loop nesting depth encoded in the code stream after the call to the stack check stub. Change the code to jump around this instruction as well as the call when the stack check is OK. Committed: http://code.google.com/p/v8/source/detail?r=6204

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -17 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +16 lines, -8 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 11 months ago (2011-01-06 13:20:38 UTC) #1
fschneider
9 years, 11 months ago (2011-01-06 13:44:18 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698