Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 60046: Apply Lei Zhang's patch to add easy import of additional environment... (Closed)

Created:
11 years, 8 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Apply Lei Zhang's patch to add easy import of additional environment variables in our scons setup. Here is an example of importing an additional environment variable: export MYVAR='value' scons importenv="MYVAR" Committed: http://code.google.com/p/v8/source/detail?r=1671

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M SConstruct View 3 chunks +7 lines, -2 lines 2 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 8 months ago (2009-04-02 12:48:17 UTC) #1
Kevin Millikin (Chromium)
11 years, 8 months ago (2009-04-02 12:54:10 UTC) #2
It seems plausible.  LGTM.

http://codereview.chromium.org/60046/diff/1/2
File SConstruct (right):

http://codereview.chromium.org/60046/diff/1/2#newcode511
Line 511: result.Add('importenv', 'import environment settings (NAME1,NAME2)',
'')
Might be clearer to have the message string:

'import environment settings (NAME1,NAME2,...)'

Also, consider zero-based indexing.  :)

http://codereview.chromium.org/60046/diff/1/2#newcode632
Line 632: # The environment imports are in the format NAME1,NAME2
Analogously here.

Powered by Google App Engine
This is Rietveld 408576698