Issue 60044: When computing pairwise merges of frame elements, we should allow...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60044: When computing pairwise merges of frame elements, we should allow... (Closed)

Created:
11 years, 8 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

When computing pairwise merges of frame elements, we should allow constants and copies below the watermark on backward jump targets (that's the whole point!). Committed: http://code.google.com/p/v8/source/detail?r=1670

Patch Set 1 #

Total comments: 1

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/jump-target.cc	View		2 chunks	+2 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

William Hesse

11 years, 8 months ago (2009-04-02 11:34:30 UTC) #2

LGTM. with comment.

http://codereview.chromium.org/60044/diff/1/2
File src/jump-target.cc (right):

http://codereview.chromium.org/60044/diff/1/2#newcode105
Line 105: // bidirectional frames cannot have constants or copies.)  If either
Update comment.

Expand Messages | Collapse Messages