Issue 6004006: Fix path filtering to be on the relative path and no on the absolute path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6004006: Fix path filtering to be on the relative path and no on the absolute path. (Closed)

Created:
9 years, 12 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Fix path filtering to be on the relative path and no on the absolute path. Add logging to presubmit_support.py. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70378

Patch Set 2 : Make pylint failure on commit an error. #

Total comments: 2

Patch Set 3 : added comment #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -27 lines)			Patch
M	PRESUBMIT.py	View	1 2	1 chunk	+14 lines, -2 lines	0 comments	Download
M	presubmit_canned_checks.py	View	1	3 chunks	+36 lines, -23 lines	0 comments	Download
M	presubmit_support.py	View		4 chunks	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nsylvain

http://codereview.chromium.org/6004006/diff/3001/PRESUBMIT.py File PRESUBMIT.py (right): http://codereview.chromium.org/6004006/diff/3001/PRESUBMIT.py#newcode28 PRESUBMIT.py:28: output.append(output_api.PresubmitError('Path inconsistency')) Do you have an example of failure ...

9 years, 12 months ago (2010-12-23 22:12:00 UTC) #2

M-A Ruel

9 years, 12 months ago (2010-12-23 23:49:52 UTC) #3

lg