Introduce a separate preference for 'proxy server mode'

chrome/browser/prefs/proxy_prefs.h

Index: chrome/browser/prefs/proxy_prefs.h
diff --git a/chrome/browser/prefs/proxy_prefs.h b/chrome/browser/prefs/proxy_prefs.h
new file mode 100644
index 0000000000000000000000000000000000000000..d4da37a260ac84adc682ffdb5399c3b37dc83cc7
--- /dev/null
+++ b/chrome/browser/prefs/proxy_prefs.h
@@ -0,0 +1,48 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_PROXY_PREFS_H_
+#define CHROME_BROWSER_PREFS_PROXY_PREFS_H_
+#pragma once
+
+#include <string>
+
+namespace ProxyPrefs {
+
+// Possible types of specifying proxy settings. Do not change the order of
+// the constants, because numeric values are exposed to users.
+// If you add an enum constant, you should also add a string to
+// kProxyModeNames in the .cc file.
+// Note that these constants serve for the internal representation in pref
+// stores. Proxy policies use a different representation, see
+// configuration_policy_store_interface.h.
+enum ProxyMode {
+  // Direct connection to the network, other proxy preferences are ignored.
+  MODE_DIRECT = 0,
+
+  // Try to retrieve a PAC script from http://wpad/wpad.dat or fall back to
+  // direct connection.
+  MODE_AUTO_DETECT = 1,
+
+  // Try to retrieve a PAC script from kProxyPacURL or fall back to direct
+  // connection.
+  MODE_PAC_SCRIPT = 2,
+
+  // Use the settings specified in kProxyServer and kProxyBypassList.
+  MODE_FIXED_SERVERS = 3,
+
+  // The system's proxy settings are used, other proxy preferences are
+  // ignored.
+  MODE_SYSTEM = 4,
+
+  NUM_MODES

[Mattias Nissler (ping if slow), 2010/12/22 10:22:12]

Shouldn't this also be prefixed by MODE_? Like MODE_COUNT or something? Style
guide says we should use kConstantNaming for new enums.

[battre, 2010/12/22 14:41:16]

Done.

+};
+
+bool IntToProxyMode(int in_value, ProxyMode* out_value);
+bool StringToProxyMode(const std::string& in_value,
+                       ProxyMode* out_value);
+
+}  // namespace
+
+#endif  // CHROME_BROWSER_PREFS_PROXY_PREFS_H_