Introduce a separate preference for 'proxy server mode'

chrome/common/pref_names.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 namespace prefs {
 
 // *************** PROFILE PREFS ***************
 // These are attached to the user profile
@@ skipping 1106 matching lines @@
 // The email address of the account used to authenticate with the Cloud Print
 // server.
 const char kCloudPrintEmail[] = "cloud_print.email";
 // Settings specific to underlying print system.
 const char kCloudPrintPrintSystemSettings[] =
     "cloud_print.print_system_settings";
 
 // Used by the service process to determine if the remoting host is enabled.
 const char kRemotingHostEnabled[] = "remoting.host_enabled";
 
-// Boolean to disable proxy altogether. If true, other proxy
-// preferences are ignored.
-const char kNoProxyServer[] = "proxy.disabled";
-// Boolean specifying if proxy should be auto-detected.
-const char kProxyAutoDetect[] = "proxy.auto_detect";
+// Integer to specify the type of proxy settings.
+// See ProxyPrefs for possible values and interactions with the other proxy
+// preferences.
+const char kProxyMode[] = "proxy.mode";

[Mattias Nissler (ping if slow), 2010/12/21 15:54:29]

Do we need conversion code for migrating legacy prefs?

[battre (please use the other), 2010/12/21 20:14:09]

We have this code in configuration_policy_pref_store.cc. There is no simple 1:1
mapping. The new format is not yet supported by policies. "proxy.mode" is only
used in the user preferences file and in extension pref stores.

[Mattias Nissler (ping if slow), 2010/12/22 10:22:11]

What I meant is whether we need to care about possible existing Preferences
files that users may have. If somebody has set up their proxy by putting
appropriate configuration in the prefs file, we break them. The question is
whether that's acceptable or not, in which case we need to provide migration
code.

[battre, 2010/12/22 14:41:16]

If a user has set no kProxyMode constant because it was not introduced before,
Chrome falls back to system proxy prefs (registered default). I think this is
reasonable, given that this feature has not seen much exposure, yet.

 // String specifying the proxy server. For a specification of the expected
 // syntax see net::ProxyConfig::ProxyRules::ParseFromString().
 const char kProxyServer[] = "proxy.server";
 // URL to the proxy .pac file.
 const char kProxyPacUrl[] = "proxy.pac_url";
 // String containing proxy bypass rules. For a specification of the
 // expected syntax see net::ProxyBypassRules::ParseFromString().
 const char kProxyBypassList[] = "proxy.bypass_list";
 
 // Preferences that are exclusivly used to store managed values for default
 // content settings.
 const char kManagedDefaultCookiesSetting[] =
     "profile.managed_default_content_settings.cookies";
 const char kManagedDefaultImagesSetting[] =
     "profile.managed_default_content_settings.images";
 const char kManagedDefaultJavaScriptSetting[] =
     "profile.managed_default_content_settings.javascript";
 const char kManagedDefaultPluginsSetting[] =
     "profile.managed_default_content_settings.plugins";
 const char kManagedDefaultPopupsSetting[] =
     "profile.managed_default_content_settings.popups";
 
 // Dictionary for storing the set of known background pages (keys are extension
 // IDs of background page owners, value is a boolean that is true if the user
 // needs to acknowledge this page.
 const char kKnownBackgroundPages[] = "background_pages.known";
 }  // namespace prefs