Introduce a separate preference for 'proxy server mode'

chrome/browser/prefs/proxy_prefs.h

+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_PROXY_PREFS_H_
+#define CHROME_BROWSER_PREFS_PROXY_PREFS_H_
+#pragma once
+
+#include <string>
+
+namespace ProxyPrefs {
+
+// Possible types of specifying proxy settings. Do not change the order of
+// the constants, because numeric values are exposed to users.
+// If you add an enum constant, you should also add a string to
+// kProxyModeNames in the .cc file.
+enum ProxyMode {
+  // Direct connection to the network, other proxy preferences are ignored.
+  kModeDirect = 0,

[eroman, 2010/12/23 01:06:15]

Note that Chrome's style is to use UPPER_CASE for enums. (even though this is
different from the official google style guide).

See:

http://www.chromium.org/developers/coding-style

[battre, 2010/12/23 09:41:42]

Done.

+
+  // Try to retrieve a PAC script from http://wpad/wpad.dat or fall back to
+  // direct connection.
+  kModeAutoDetect = 1,
+
+  // Try to retrieve a PAC script from kProxyPacURL or fall back to direct
+  // connection.
+  kModePacScript = 2,
+
+  // Use the settings specified in kProxyServer and kProxyBypassList.
+  kModeFixedServers = 3,
+
+  // The system's proxy settings are used, other proxy preferences are
+  // ignored.
+  kModeSystem = 4,
+
+  kModeCount
+};
+
+bool IntToProxyMode(int in_value, ProxyMode* out_value);
+bool StringToProxyMode(const std::string& in_value,
+                       ProxyMode* out_value);
+
+}  // namespace

[eroman, 2010/12/23 01:06:15]

nit: "// namespace ProxyPrefs"

[battre, 2010/12/23 09:41:42]

Done.

+
+#endif  // CHROME_BROWSER_PREFS_PROXY_PREFS_H_