A simple fix of issue http://code.google.com/p/chromium/issues/detail?id=3285...

test/cctest/test-api.cc

 // Copyright 2007-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 4539 matching lines @@
   // must work for non-function receivers.
   const char* apply_99 = "Function.prototype.call.apply(obj, [this, 99])";
   value = Script::Compile(v8_str(apply_99))->Run();
   CHECK(!try_catch.HasCaught());
   CHECK_EQ(99, value->Int32Value());
 
   const char* call_17 = "Function.prototype.call.call(obj, this, 17)";
   value = Script::Compile(v8_str(call_17))->Run();
   CHECK(!try_catch.HasCaught());
   CHECK_EQ(17, value->Int32Value());
-
-  // Try something that will cause an exception: Call the object as a

[Mads Ager (chromium), 2009/04/28 10:50:15]

Please add a test case for the intended behavior of construct calls.

[Feng Qian, 2009/04/30 23:26:15]

This needs to be tested by a layout test. V8 treats construct call and function
call as the same if an object can be called as the function.

Like I said in TODO: V8 needs to pass different flags to the callback function,
or make two different API for callAsFunction and callAsConstruct.

On 2009/04/28 10:50:15, Mads Ager wrote:

-  // constructor. This should be the last test.
-  value = Script::Compile(v8_str("new obj(42)"))->Run();
-  CHECK(try_catch.HasCaught());
 }
 
 
 static int CountHandles() {
   return v8::HandleScope::NumberOfHandles();
 }
 
 
 static int Recurse(int depth, int iterations) {
   v8::HandleScope scope;
@@ skipping 1554 matching lines @@
   // Check without 'eval' or 'with'.
   v8::Handle<v8::Value> res =
       CompileRun("function f() { x = 42; return x; }; f()");
   // Check with 'eval'.
   res = CompileRun("function f() { eval('1'); y = 42; return y; }; f()");
   CHECK_EQ(v8::Integer::New(42), res);
   // Check with 'with'.
   res = CompileRun("function f() { with (this) { y = 42 }; return y; }; f()");
   CHECK_EQ(v8::Integer::New(42), res);
 }