Fix crash in JingleThread caused by non-nestable tasks.

Fix crash in JingleThread caused by non-nestable tasks.

BUG=None
TEST=Unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70115

[awong, 2010-12-23 01:16:44]

one nit.

http://codereview.chromium.org/6003003/diff/1/remoting/jingle_glue/jingle_thr...
File remoting/jingle_glue/jingle_thread.cc (right):

http://codereview.chromium.org/6003003/diff/1/remoting/jingle_glue/jingle_thr...
remoting/jingle_glue/jingle_thread.cc:80:
ALLOW_THIS_IN_INITIALIZER_LIST(jingle_message_loop_state_(this)) {
I'd actually throw this out of the constructor.  This is a bit odd since
AutoRunState modifies the message loop you passed in, but the message loop is
still being constructed.  So, who knows what will happen to state_....

[Sergey Ulanov, 2010-12-23 01:22:50]

http://codereview.chromium.org/6003003/diff/1/remoting/jingle_glue/jingle_thr...
File remoting/jingle_glue/jingle_thread.cc (right):

http://codereview.chromium.org/6003003/diff/1/remoting/jingle_glue/jingle_thr...
remoting/jingle_glue/jingle_thread.cc:80:
ALLOW_THIS_IN_INITIALIZER_LIST(jingle_message_loop_state_(this)) {
On 2010/12/23 01:16:44, awong wrote:
> I'd actually throw this out of the constructor.  This is a bit odd since
> AutoRunState modifies the message loop you passed in, but the message loop is
> still being constructed.  So, who knows what will happen to state_....

Yes. Good catch.

[awong, 2010-12-23 23:02:49]

LGTM w/ one nit

http://codereview.chromium.org/6003003/diff/5001/remoting/jingle_glue/jingle_...
File remoting/jingle_glue/jingle_thread.cc (right):

http://codereview.chromium.org/6003003/diff/5001/remoting/jingle_glue/jingle_...
remoting/jingle_glue/jingle_thread.cc:126: message_loop.Initialize();
Do this before assigning it to the member variable. This is mainly OCD...but I
get weirded out by the message_loop_ on the preiovus line, and the message_loop.
on this line...

[Sergey Ulanov, 2010-12-23 23:37:53]

http://codereview.chromium.org/6003003/diff/5001/remoting/jingle_glue/jingle_...
File remoting/jingle_glue/jingle_thread.cc (right):

http://codereview.chromium.org/6003003/diff/5001/remoting/jingle_glue/jingle_...
remoting/jingle_glue/jingle_thread.cc:126: message_loop.Initialize();
On 2010/12/23 23:02:49, awong wrote:
> Do this before assigning it to the member variable. This is mainly OCD...but I
> get weirded out by the message_loop_ on the preiovus line, and the
message_loop.
> on this line...

Done.