chrome/browser/policy/configuration_policy_pref_store_unittest.cc - Issue 6002015: Policy: generate boilerplate policy type and constant code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/configuration_policy_pref_store_unittest.cc

Issue 6002015: Policy: generate boilerplate policy type and constant code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tweaks and right diff Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/policy/policy_templates.gypi ('K') | « chrome/browser/policy/configuration_policy_pref_store.cc ('k') | chrome/browser/policy/configuration_policy_provider_mac_unittest.cc » ('j') | chrome/browser/policy/configuration_policy_store_interface.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/configuration_policy_pref_store_unittest.cc

diff --git a/chrome/browser/policy/configuration_policy_pref_store_unittest.cc b/chrome/browser/policy/configuration_policy_pref_store_unittest.cc

index f6a917c1a7276cab5395a44a5a622f292bbf83ef..e453ba2d5c8261af54b62a7fe343394f4e90cc62 100644

--- a/chrome/browser/policy/configuration_policy_pref_store_unittest.cc

+++ b/chrome/browser/policy/configuration_policy_pref_store_unittest.cc

@@ -71,11 +71,11 @@ INSTANTIATE_TEST_CASE_P(

ConfigurationPolicyPrefStoreListTestInstance,

ConfigurationPolicyPrefStoreListTest,

testing::Values(

- TypeAndName(kPolicyURLsToRestoreOnStartup,

+ TypeAndName(kPolicyRestoreOnStartupURLs,

prefs::kURLsToRestoreOnStartup),

- TypeAndName(kPolicyExtensionInstallAllowList,

+ TypeAndName(kPolicyExtensionInstallWhitelist,

prefs::kExtensionInstallAllowList),

- TypeAndName(kPolicyExtensionInstallDenyList,

+ TypeAndName(kPolicyExtensionInstallBlacklist,

prefs::kExtensionInstallDenyList),

TypeAndName(kPolicyDisabledPlugins,

prefs::kPluginsPluginsBlacklist)));

@@ -105,11 +105,11 @@ INSTANTIATE_TEST_CASE_P(

ConfigurationPolicyPrefStoreStringTestInstance,

ConfigurationPolicyPrefStoreStringTest,

testing::Values(

- TypeAndName(kPolicyHomePage,

+ TypeAndName(kPolicyHomepageLocation,

prefs::kHomePage),

- TypeAndName(kPolicyApplicationLocale,

+ TypeAndName(kPolicyApplicationLocaleValue,

prefs::kApplicationLocale),

- TypeAndName(kPolicyApplicationLocale,

+ TypeAndName(kPolicyApplicationLocaleValue,

prefs::kApplicationLocale),

TypeAndName(kPolicyAuthSchemes,

prefs::kAuthSchemes),

@@ -650,7 +650,7 @@ TEST_F(ConfigurationPolicyPrefStoreRefreshTest, Refresh) {

store_.GetValue(prefs::kHomePage, NULL));

EXPECT_CALL(observer_, OnPrefValueChanged(prefs::kHomePage)).Times(1);

- provider_.AddPolicy(kPolicyHomePage,

+ provider_.AddPolicy(kPolicyHomepageLocation,

Value::CreateStringValue("http://www.chromium.org"));

store_.OnUpdatePolicy();

Mock::VerifyAndClearExpectations(&observer_);

@@ -663,7 +663,7 @@ TEST_F(ConfigurationPolicyPrefStoreRefreshTest, Refresh) {

Mock::VerifyAndClearExpectations(&observer_);

EXPECT_CALL(observer_, OnPrefValueChanged(prefs::kHomePage)).Times(1);

- provider_.RemovePolicy(kPolicyHomePage);

+ provider_.RemovePolicy(kPolicyHomepageLocation);

store_.OnUpdatePolicy();

Mock::VerifyAndClearExpectations(&observer_);

EXPECT_EQ(PrefStore::READ_NO_VALUE,