Issue 6002013: Move the SetProcTitle code out of base and into chrome/common. This is only...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6002013: Move the SetProcTitle code out of base and into chrome/common. This is only... (Closed)

Created:
9 years, 12 months ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
use derat at chromium.org, Daniel Erat

CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, apatrick_chromium, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Move the SetProcTitle code out of base and into chrome/common. This is only used to support the weird way Chrome manages processes, so doesn't belong in the central CommandLine class. This also provides an empty implementation on Mac & Windows to avoid some ifdefs in the main functions. TEST=everything compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70276

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -726 lines)			Patch
M	base/base.gypi	View	1 2 3	2 chunks	+0 lines, -4 lines	0 comments	Download
M	base/command_line.h	View		2 chunks	+1 line, -9 lines	0 comments	Download
M	base/command_line.cc	View		3 chunks	+8 lines, -62 lines	0 comments	Download
D	base/setproctitle_linux.h	View		1 chunk	+0 lines, -28 lines	0 comments	Download
D	base/setproctitle_linux.c	View		1 chunk	+0 lines, -115 lines	0 comments	Download
M	chrome/app/chrome_main.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/zygote_main_linux.cc	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/chrome_common.gypi	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/common/set_process_title.h	View	1 2 3	1 chunk	+25 lines, -0 lines	0 comments	Download
A +	chrome/common/set_process_title.cc	View		2 chunks	+22 lines, -477 lines	0 comments	Download
A +	chrome/common/set_process_title_linux.h	View		1 chunk	+6 lines, -11 lines	0 comments	Download
A +	chrome/common/set_process_title_linux.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/gpu/gpu_main.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/plugin/plugin_main.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/ppapi_plugin/ppapi_plugin_main.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 6002013: Move the SetProcTitle code out of base and into chrome/common. This is only... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages