Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 60019: Move a bunch of libs over to gyp on windows. (Closed)

Created:
11 years, 8 months ago by bradn
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/
Visibility:
Public.

Description

Move a bunch of libs over to gyp on windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13020

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -761 lines) Patch
M build/all.gyp View 1 2 chunks +16 lines, -13 lines 0 comments Download
M chrome/chrome.sln View 1 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/libxml/build/libxml.vcproj View 1 1 chunk +0 lines, -519 lines 0 comments Download
D third_party/libxslt/build/libxslt.vcproj View 1 1 chunk +0 lines, -225 lines 0 comments Download
M webkit/webkit.sln View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bradn
11 years, 8 months ago (2009-04-01 18:32:53 UTC) #1
bradn
Property changes on: third_party\libxslt ___________________________________________________________________ Modified: svn:ignore - config.h libxslt.xcodeproj + config.h libxslt.xcodeproj libxslt.vcproj libxslt.sln ...
11 years, 8 months ago (2009-04-01 18:37:28 UTC) #2
Mark Mentovai
http://codereview.chromium.org/60019/diff/1/5 File build/all.gyp (right): http://codereview.chromium.org/60019/diff/1/5#newcode32 Line 32: '../third_party/libevent/libevent.gyp:*', Really? We don't use libevent on Windows, ...
11 years, 8 months ago (2009-04-02 05:03:19 UTC) #3
bradn
11 years, 8 months ago (2009-04-02 16:29:11 UTC) #4
http://codereview.chromium.org/60019/diff/1/5
File build/all.gyp (right):

http://codereview.chromium.org/60019/diff/1/5#newcode32
Line 32: '../third_party/libevent/libevent.gyp:*',
On 2009/04/02 05:03:19, Mark Mentovai wrote:
> Really?  We don't use libevent on Windows, do we?
True, but thought we eventually  would want to move everything out of all_gyps?
I suppose sandbox was done by platform, I'll do the same here.

http://codereview.chromium.org/60019/diff/1/5#newcode40
Line 40: '../third_party/zlib/zlib.gyp:*',
On 2009/04/02 05:03:19, Mark Mentovai wrote:
> Don't you need to remove the checked-in .vcprojs for a lot of these too?
Many of these like zlib, libjpeg, libpng, modp_b64, sqlite.
npapi is not used directly, just some headers I believe, should it be elsewhere?

Powered by Google App Engine
This is Rietveld 408576698