Issue 6001009: increase max ROM layout regions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6001009: increase max ROM layout regions (Closed)

Created:
9 years, 11 months ago by dhendrix

Modified:
9 years, 5 months ago

Reviewers:
stefanreinauer, Louis

CC:
Louis

Base URL:
svn://coreboot.org/flashrom/trunk

Visibility:
Public.

Description

increase max ROM layout regions This increases the number of maximum ROM layout regions in ancitipation for a general increase due to pending inclusion of flashmap (fmap). This should be enough to account for all current usage cases in addition to partial write testing scenarios. BUG=doesn't exist... yet. TEST=of course not :-)

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	layout.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dhendrix

9 years, 11 months ago (2011-01-04 20:55:31 UTC) #3

Stefan's commented didn't get picked up by Reitveld for some reason:
"Should/can we handle this dynamically? It may not be worth the effort, since
the amount of RAM consumed is minimal .. and of course 64 entries should be
enough for anyone ;)"

Dynamic allocation would be nice... Maybe in the future we'll run into a testing
case that will make dynamic allocation more appealing. But for now, I don't
think it's worth the effort.

Expand Messages | Collapse Messages