Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 6001005: [binutils] Force assembler to align code section size (Closed)

Created:
10 years ago by eaeltsin
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[binutils] Force assembler to align code section size Assembler pads code sections with NOPs, which is exactly what we need for NaCl. This change introduces NOP padding at the end of the code section. Whitout this change, linker may add zero padding to code sections, which does not validate. BUG=http://code.google.com/p/nativeclient/issues/detail?id=499 TEST=code sections in object files should be padded with NOPs at the end when needed Committed: http://git.chromium.org/gitweb/?p=nacl-toolchain.git;a=commit;h=feaa0af

Patch Set 1 #

Patch Set 2 : ready for code review #

Patch Set 3 : ready for code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M binutils/gas/config/tc-i386.c View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eaeltsin
10 years ago (2010-12-21 16:47:03 UTC) #1
pasko-google - do not use
10 years ago (2010-12-21 17:55:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698