Issue 600021: Allow opacity in themes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 600021: Allow opacity in themes. (Closed)

Created:
10 years, 10 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Allow opacity in themes. BUG=http://crbug.com/34855 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38514

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/cocoa/browser_window_controller.mm	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

10 years, 10 months ago (2010-02-09 21:49:56 UTC) #2

Very happy :). LGTM.

http://codereview.chromium.org/600021/diff/1/2
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/600021/diff/1/2#newcode272
chrome/browser/cocoa/browser_window_controller.mm:272: [window setOpaque:NO]; 
// for themes wanting to play with opacity
Make this a full-stop sentence.

Expand Messages | Collapse Messages