Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 600019: V8 does not invoke the code section registration API, when code-stubs are gen...

Created:
10 years, 10 months ago by Dineel
Modified:
10 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

V8 does not invoke the code section registration API, when code-stubs are generated. These dynamically generated code segments therefore show up in the OPROFILE output as annonymous sections. This change updates the source to register the code stub's as if they were code segments with valid associated symbol information. This allows OPROFILE to correctly identify samples occuring in these code segments giving meaningful profiles related to these sections. BUG=none TEST=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +8 lines, -0 lines 1 comment Download

Messages

Total messages: 1 (0 generated)
mnaganov (inactive)
10 years, 10 months ago (2010-02-10 17:39:57 UTC) #1
Looks good except for an unneeded define check. I'll remove it prior to
committing.

http://codereview.chromium.org/600019/diff/1/3
File src/code-stubs.cc (right):

http://codereview.chromium.org/600019/diff/1/3#newcode67
src/code-stubs.cc:67: #if defined ENABLE_LOGGING_AND_PROFILING || defined
ENABLE_OPROFILE_AGENT
A check for ENABLE_LOGGING_AND_PROFILING isn't needed here. In all other places
they are together because usually calculations are performed for both reports.
I'll remove the check prior to committing, leaving only ENABLE_OPROFILE_AGENT.

Powered by Google App Engine
This is Rietveld 408576698