Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4242)

Unified Diff: chrome_frame/test/chrome_frame_automation_mock.h

Issue 5998006: Clean up Automation and Chrome Frame IPC code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome_frame/test/automation_client_mock.cc ('k') | chrome_frame/test/url_request_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/chrome_frame_automation_mock.h
===================================================================
--- chrome_frame/test/chrome_frame_automation_mock.h (revision 69966)
+++ chrome_frame/test/chrome_frame_automation_mock.h (working copy)
@@ -98,7 +98,7 @@
QuitMessageLoop();
}
- virtual void OnLoad(int tab_handle, const GURL& url) {
+ virtual void OnLoad(const GURL& url) {
if (url_ == url) {
navigation_result_ = true;
} else {
@@ -169,8 +169,8 @@
: Base(caller_message_loop, launch_timeout, true, L"", L"", L"", false,
false) {
}
- virtual void OnLoad(int tab_handle, const GURL& url) {
- Base::OnLoad(tab_handle, url);
+ virtual void OnLoad(const GURL& url) {
+ Base::OnLoad(url);
QuitMessageLoop();
}
};
@@ -187,14 +187,13 @@
bool postmessage_result() const {
return postmessage_result_;
}
- virtual void OnLoad(int tab_handle, const GURL& url) {
- Base::OnLoad(tab_handle, url);
+ virtual void OnLoad(const GURL& url) {
+ Base::OnLoad(url);
if (navigation_result()) {
automation()->ForwardMessageFromExternalHost("Test", "null", "*");
}
}
- virtual void OnMessageFromChromeFrame(int tab_handle,
- const std::string& message,
+ virtual void OnMessageFromChromeFrame(const std::string& message,
const std::string& origin,
const std::string& target) {
postmessage_result_ = true;
@@ -220,13 +219,13 @@
bool request_start_result() const {
return request_start_result_;
}
- virtual void OnRequestStart(int tab_handle, int request_id,
- const IPC::AutomationURLRequest& request) {
+ virtual void OnRequestStart(int request_id,
+ const AutomationURLRequest& request) {
request_start_result_ = true;
QuitMessageLoop();
}
- virtual void OnLoad(int tab_handle, const GURL& url) {
- Base::OnLoad(tab_handle, url);
+ virtual void OnLoad(const GURL& url) {
+ Base::OnLoad(url);
}
private:
bool request_start_result_;
« no previous file with comments | « chrome_frame/test/automation_client_mock.cc ('k') | chrome_frame/test/url_request_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698