1. Added support for object printing for release mode using the...

1. Added support for object printing for release mode using the
   objectprint=on (defaults to off) option (which defines OBJECT_PRINT).
2. Added the ability to print objects to a specified file instead of
   just stdout.
3. Added a use_verbose_printer flag (true by default) to allow some
   object printouts to be less verbose when the flag is false.
4. Fixed a bug in VSNPrintF() where it can potentially write into an
   empty char vector.

Committed: http://code.google.com/p/v8/source/detail?r=6080

[marklam, 2010-12-17 13:13:01]

Søren, can you have a look at this change, please?

The bulk of this change is to split out object printing functions under the
OBJECT_PRINT #define symbol instead of DEBUG. This allows us to enable this
functionality in release builds if desired.  Ideally, these OBJECT_PRINT
functions (which are staggered through out objects-debug.cc) can be re-factored
out into an objects-printer.cc, but I left them where they are to make it easier
to diff and show that I didn't change any code.  The refactoring into a separate
file (if desired) can be applied in a subsequent patch.

The other bulk of the change is to allow re-directing of the print output to a
specified file instead of being hardwired to stdout.  This is needed for other
functionality that I'll submit in a subsequent patch.

I've updated the files for platform-nullos.cc and platform-win32.cc as well, but
I'm only able to test the changes on macos and linux.  This set of mods have
been built successfully with scons for debug mode, release more, and release
more + objectprint=on.

Thanks.

[Søren Thygesen Gjesse, 2010-12-17 13:44:03]

LGTM, with comment addressed.

When this is landed please make the refactoring of all the printing into
objects-printer.cc as suggested.

http://codereview.chromium.org/5998001/diff/35001/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/5998001/diff/35001/src/objects.h#newcode612
src/objects.h:612: void Print(FILE* out = stdout);
The Google C++ Style Guide does not allow default arguments (see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Defaul...),
so plaese make these Print functions into 2 functions. I know we have default
arguments in the code, as we missed that part of the style guide, but new code
should adhere.

[marklam, 2010-12-17 14:32:19]

On 2010/12/17 13:44:03, Søren Gjesse wrote:
> LGTM, with comment addressed.
> 
> When this is landed please make the refactoring of all the printing into
> objects-printer.cc as suggested.

Will do.  Do you want me to factor out the inline printer functions in objects.h
into a objects-printer-inl.h file as well?

> http://codereview.chromium.org/5998001/diff/35001/src/objects.h
> File src/objects.h (right):
> 
> http://codereview.chromium.org/5998001/diff/35001/src/objects.h#newcode612
> src/objects.h:612: void Print(FILE* out = stdout);
> The Google C++ Style Guide does not allow default arguments (see
>
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Defaul...),
> so plaese make these Print functions into 2 functions. I know we have default
> arguments in the code, as we missed that part of the style guide, but new code
> should adhere.

Done.  Replaced the default arg implementation with an overloaded peer inline
function that calls the respective print function with the would-be default arg
instead.  These changes are only needed and done in objects.h and v8utils.h.

[Søren Thygesen Gjesse, 2010-12-20 10:43:42]

LGTM, committed r6080.

I don't think we need objects-printer-inl.h, we only use them for inlining
larger functions, see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=The_-i....

I updated tools/gyp/v8.gyp, xcode anf Visual Studio files before committing.

Thank you for the patch.

Closing issue.