Issue 5996006: Expand the suppression for bug 68304 (leaks in ResourceDispatcherHostTest.*)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5996006: Expand the suppression for bug 68304 (leaks in ResourceDispatcherHostTest.*)... (Closed)

Created:
9 years, 11 months ago by Alexander Potapenko

Modified:
9 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Expand the suppression for bug 68304 (leaks in ResourceDispatcherHostTest.*) BUG=68304 TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70337

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View		2 chunks	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

9 years, 11 months ago (2011-01-04 21:29:44 UTC) #2

lgtm

On Fri, Dec 31, 2010 at 3:07 AM, <glider@chromium.org> wrote:

> Reviewers: John Abd-El-Malek,
>
> Message:
> TBR
>
> Description:
> Expand the suppression for bug 68304 (leaks in
> ResourceDispatcherHostTest.*)
>
> BUG=68304
> TBR=jam
>
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70337
>
> Please review this at http://codereview.chromium.org/5996006/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/heapcheck/suppressions.txt
>
>
> Index: tools/heapcheck/suppressions.txt
> ===================================================================
> --- tools/heapcheck/suppressions.txt    (revision 70335)
> +++ tools/heapcheck/suppressions.txt    (working copy)
> @@ -721,7 +721,7 @@
>    fun:std::string::_Rep::_S_create
>    fun:std::string::_Rep::_M_clone
>    fun:std::string::reserve
> -   fun:bool ::InitCanonical
> +   fun:*InitCanonical
>    fun:GURL
>    fun:net::::IOThread::Init
>    fun:base::Thread::ThreadMain
> @@ -1193,12 +1193,6 @@
>  {
>    bug_68304
>    Heapcheck:Leak
> -   fun:__gnu_cxx::new_allocator::allocate
> -   fun:std::string::_Rep::_S_create
> -   fun:std::string::_M_mutate
> -   fun:std::string::_M_replace_safe
> -   fun:std::string::assign
> -   fun:Pickle::ReadString
>    ...
>    fun:IPC::ParamTraits::Read
>    fun:IPC::ReadParam
>
>
>

Expand Messages | Collapse Messages