Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 5995011: Simplify the accounts options page markup. (Closed)

Created:
9 years, 11 months ago by satorux1
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Simplify the accounts options page markup. Per comment from arv, move the background image from span to div, and remove the span element. The previous patch: http://codereview.chromium.org/5965003/ BUG=confirmed that the page was displayed properly TEST=chromium-os:9254 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M chrome/browser/resources/options/chromeos_accounts_options.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options/chromeos_accounts_options_page.css View 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
satorux1
9 years, 11 months ago (2011-01-05 08:22:44 UTC) #1
kochi
LGTM
9 years, 11 months ago (2011-01-05 09:23:11 UTC) #2
arv (Not doing code reviews)
9 years, 11 months ago (2011-01-05 18:13:16 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698