Issue 5995003: Workaround the fact that pylint calls sys.exit().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5995003: Workaround the fact that pylint calls sys.exit(). (Closed)

Created:
10 years ago by M-A Ruel

Modified:
9 years, 5 months ago

Reviewers:
Nicolas Sylvain, commit-bot: I haz the power, nsylvain

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Workaround the fact that pylint calls sys.exit(). Otherwise the following presubmit checks where never called. TBR=nsylvain BUG= TEST=fixes unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69844

Patch Set 1 #

Patch Set 2 : fix presubmit check while at it #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	presubmit_canned_checks.py	View		2 chunks	+7 lines, -3 lines	0 comments	Download
	M	trychange.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patch failed to apply against 70108.

9 years, 11 months ago (2011-01-03 02:35:03 UTC) #3

commit-bot: I haz the power

Patch failed to apply against 70108.

9 years, 11 months ago (2011-01-03 02:39:45 UTC) #4

commit-bot: I haz the power

9 years, 5 months ago (2011-07-19 19:57:21 UTC) #5

Can't apply patch for file presubmit_canned_checks.py.
While running patch -p1 --forward --force;
patching file presubmit_canned_checks.py
Hunk #1 FAILED at 494.
Hunk #2 FAILED at 507.
2 out of 2 hunks FAILED -- saving rejects to file presubmit_canned_checks.py.rej

Expand Messages | Collapse Messages