Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 5992011: Fix a bug in deoptimization environments. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix a bug in deoptimization environments. The function HEnvironment::SetExpressionStackAt did not update the environment's history. This function is used to patch the bailout environment for count operations and global function calls. Reorganize class HEnvironment to make it fit V8's style a bit better and to try to add some sanity to which C++ functions are intended to be inlined. Remove the flag --trace-environment which merely duplicated data in the hydrogen.cfg file except without enough context to be useful. BUG=1004 Committed: http://code.google.com/p/v8/source/detail?r=6137

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -114 lines) Patch
M src/arm/lithium-arm.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.h View 5 chunks +48 lines, -61 lines 0 comments Download
M src/hydrogen.cc View 9 chunks +57 lines, -25 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 3 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
I couldn't find a simple way to trigger this in a test.
9 years, 11 months ago (2011-01-03 16:09:31 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 11 months ago (2011-01-03 16:22:32 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698