Issue 599020: Implemented linux-specific NPAPI interface for pepper demos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 599020: Implemented linux-specific NPAPI interface for pepper demos. (Closed)

Created:
10 years, 10 months ago by alokp

Modified:
9 years, 6 months ago

Reviewers:
apatrick, apatrick_chromium, piman

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Implemented linux-specific NPAPI interface for pepper demos. BUG=26099 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38727

Patch Set 3 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -7 lines)			Patch
	M	gpu/demos/framework/main_pepper.cc	View	1 2	4 chunks	+46 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

apatrick

lgtm http://codereview.chromium.org/599020/diff/1/2 File gpu/demos/framework/main_pepper.cc (right): http://codereview.chromium.org/599020/diff/1/2#newcode97 gpu/demos/framework/main_pepper.cc:97: *((const char**)value) = "Pepper GPU Demo"; static_cast instead ...

10 years, 10 months ago (2010-02-10 18:24:29 UTC) #3

alokp

10 years, 10 months ago (2010-02-10 20:04:38 UTC) #4

http://codereview.chromium.org/599020/diff/1/2
File gpu/demos/framework/main_pepper.cc (right):

http://codereview.chromium.org/599020/diff/1/2#newcode97
gpu/demos/framework/main_pepper.cc:97: *((const char**)value) = "Pepper GPU
Demo";
On 2010/02/10 18:24:29, apatrick wrote:
> static_cast instead of c-style cast here and 2 below.

Done.

Expand Messages | Collapse Messages

Issue 599020: Implemented linux-specific NPAPI interface for pepper demos. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages