[Mac] Add local storage nodes to the cookie manager

[Mac] Add local storage nodes to the cookie manager

* Add local storage getters to CookieTreeNode
* XIB: Embed cookie info labels into an NSView (inside the NSBox) and add
  another for info NSView for local storage.
* Roll GTM r280:293

BUG=33068
TEST=Chromium-->Preferences-->Under the Hood-->Show cookies... Find and click on a local storage node. Info should be displayed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38504

[TVL, 2010-02-09 15:33:53]

http://codereview.chromium.org/599003/diff/1/4
File chrome/browser/cocoa/cookie_tree_node.h (right):

http://codereview.chromium.org/599003/diff/1/4#newcode29
chrome/browser/cocoa/cookie_tree_node.h:29: BOOL isLeaf_;
why do we need isLeaf if we have a type which says folder?

http://codereview.chromium.org/599003/diff/1/5
File chrome/browser/cocoa/cookie_tree_node.mm (right):

http://codereview.chromium.org/599003/diff/1/5#newcode28
chrome/browser/cocoa/cookie_tree_node.mm:28: children_.reset();
this doesn't reset isLeaf_

http://codereview.chromium.org/599003/diff/1/5#newcode71
chrome/browser/cocoa/cookie_tree_node.mm:71: }
else NOTIMPL() to catch if a new type gets created without this code getting
updated?

http://codereview.chromium.org/599003/diff/1/6
File chrome/browser/cocoa/cookies_window_controller.h (right):

http://codereview.chromium.org/599003/diff/1/6#newcode99
chrome/browser/cocoa/cookies_window_controller.h:99: // cookie and local storage
views.
why not just two views that you show/hide?  ie-why take the weight of a tabview
when you don't need it?  will the tabview show up in voice over where show/hide
of views won't?

http://codereview.chromium.org/599003/diff/1/7
File chrome/browser/cocoa/cookies_window_controller.mm (right):

http://codereview.chromium.org/599003/diff/1/7#newcode348
chrome/browser/cocoa/cookies_window_controller.mm:348: [self
setDetailedViewTabIndex:(nodeType > 0 ? nodeType - 1 : 0)];
don't do this.  if you have an enum for type, you should always use the constant
names not the values.  this is how you get bugs when someone makes a change to
the enum and suddenly the magic values aren't true.

[Robert Sesek, 2010-02-09 17:03:45]

http://codereview.chromium.org/599003/diff/1/4
File chrome/browser/cocoa/cookie_tree_node.h (right):

http://codereview.chromium.org/599003/diff/1/4#newcode29
chrome/browser/cocoa/cookie_tree_node.h:29: BOOL isLeaf_;
On 2010/02/09 15:33:53, TVL wrote:
> why do we need isLeaf if we have a type which says folder?

Removed.

http://codereview.chromium.org/599003/diff/1/5
File chrome/browser/cocoa/cookie_tree_node.mm (right):

http://codereview.chromium.org/599003/diff/1/5#newcode71
chrome/browser/cocoa/cookie_tree_node.mm:71: }
On 2010/02/09 15:33:53, TVL wrote:
> else NOTIMPL() to catch if a new type gets created without this code getting
> updated?

No, because there are a lot more types than these two. These are the only two
whose detailed info we use, though.

http://codereview.chromium.org/599003/diff/1/6
File chrome/browser/cocoa/cookies_window_controller.h (right):

http://codereview.chromium.org/599003/diff/1/6#newcode99
chrome/browser/cocoa/cookies_window_controller.h:99: // cookie and local storage
views.
On 2010/02/09 15:33:53, TVL wrote:
> why not just two views that you show/hide?  ie-why take the weight of a
tabview
> when you don't need it?  will the tabview show up in voice over where
show/hide
> of views won't?

Ok, switched to two views that we hide/show.

[pink (ping after 24hrs), 2010-02-09 17:24:58]

http://codereview.chromium.org/599003/diff/16/4003
File chrome/browser/cocoa/cookie_tree_node.h (right):

http://codereview.chromium.org/599003/diff/16/4003#newcode10
chrome/browser/cocoa/cookie_tree_node.h:10: // The type of node a TreeNode is.
This also corresponds to the tab identifier
Bad grammar. Fix.

http://codereview.chromium.org/599003/diff/16/4003#newcode25
chrome/browser/cocoa/cookie_tree_node.h:25: @interface CocoaCookieTreeNode :
NSObject {
Why not do this with inheritance, rather than enums and a aggregation of all
members/methods? Seems very C-like for no reason.

http://codereview.chromium.org/599003/diff/16/4006
File chrome/browser/cocoa/cookies_window_controller.mm (right):

http://codereview.chromium.org/599003/diff/16/4006#newcode337
chrome/browser/cocoa/cookies_window_controller.mm:337: NSUInteger childIndex =
[selection indexAtPosition:i];
i guess this container doesn't support fast-enumeration?

http://codereview.chromium.org/599003/diff/16/4006#newcode338
chrome/browser/cocoa/cookies_window_controller.mm:338: if (childIndex >= [[node
children] count]) {
DCHECK?

[Robert Sesek, 2010-02-09 18:35:43]

http://codereview.chromium.org/599003/diff/16/4003
File chrome/browser/cocoa/cookie_tree_node.h (right):

http://codereview.chromium.org/599003/diff/16/4003#newcode10
chrome/browser/cocoa/cookie_tree_node.h:10: // The type of node a TreeNode is.
This also corresponds to the tab identifier
On 2010/02/09 17:24:58, pink wrote:
> Bad grammar. Fix.

Done.

http://codereview.chromium.org/599003/diff/16/4003#newcode25
chrome/browser/cocoa/cookie_tree_node.h:25: @interface CocoaCookieTreeNode :
NSObject {
On 2010/02/09 17:24:58, pink wrote:
> Why not do this with inheritance, rather than enums and a aggregation of all
> members/methods? Seems very C-like for no reason.

That was my original intent, but bindings + inheritance = unhappy.

http://codereview.chromium.org/599003/diff/16/4006
File chrome/browser/cocoa/cookies_window_controller.mm (right):

http://codereview.chromium.org/599003/diff/16/4006#newcode337
chrome/browser/cocoa/cookies_window_controller.mm:337: NSUInteger childIndex =
[selection indexAtPosition:i];
On 2010/02/09 17:24:58, pink wrote:
> i guess this container doesn't support fast-enumeration?

I do not believe so, no.

http://codereview.chromium.org/599003/diff/16/4006#newcode338
chrome/browser/cocoa/cookies_window_controller.mm:338: if (childIndex >= [[node
children] count]) {
On 2010/02/09 17:24:58, pink wrote:
> DCHECK?

Putting in a DHCECK() means the test I wrote to exercise this block will crash.
I prefer code coverage over a DCHECK(), especially because this should never
happen.

[pink (ping after 24hrs), 2010-02-09 20:51:21]

LGTM with comments.

http://codereview.chromium.org/599003/diff/7001/6004
File chrome/browser/cocoa/cookie_tree_node.h (right):

http://codereview.chromium.org/599003/diff/7001/6004#newcode10
chrome/browser/cocoa/cookie_tree_node.h:10: // This enum specifies the type of
display node a CocoaCookieTreeNode is.
Can you add a comment here about switching this to inheritance if you rewrite
this not to use bindings?

http://codereview.chromium.org/599003/diff/7001/6005
File chrome/browser/cocoa/cookie_tree_node.mm (right):

http://codereview.chromium.org/599003/diff/7001/6005#newcode103
chrome/browser/cocoa/cookie_tree_node.mm:103: return (nodeType_ !=
kCocoaCookieTreeNodeTypeFolder);
no need for parens.

http://codereview.chromium.org/599003/diff/7001/6007
File chrome/browser/cocoa/cookies_window_controller.mm (right):

http://codereview.chromium.org/599003/diff/7001/6007#newcode321
chrome/browser/cocoa/cookies_window_controller.mm:321: // Multi-selection should
be disabled in the UI, but for sanity, double-check
why can't i select multiple items? seems like i might want to erase a few
cookies at a time w/out having to remove them all, no?

[Robert Sesek, 2010-02-09 20:58:13]

http://codereview.chromium.org/599003/diff/7001/6004
File chrome/browser/cocoa/cookie_tree_node.h (right):

http://codereview.chromium.org/599003/diff/7001/6004#newcode10
chrome/browser/cocoa/cookie_tree_node.h:10: // This enum specifies the type of
display node a CocoaCookieTreeNode is.
On 2010/02/09 20:51:21, pink wrote:
> Can you add a comment here about switching this to inheritance if you rewrite
> this not to use bindings?

Done.

http://codereview.chromium.org/599003/diff/7001/6005
File chrome/browser/cocoa/cookie_tree_node.mm (right):

http://codereview.chromium.org/599003/diff/7001/6005#newcode103
chrome/browser/cocoa/cookie_tree_node.mm:103: return (nodeType_ !=
kCocoaCookieTreeNodeTypeFolder);
On 2010/02/09 20:51:21, pink wrote:
> no need for parens.

Done.

http://codereview.chromium.org/599003/diff/7001/6007
File chrome/browser/cocoa/cookies_window_controller.mm (right):

http://codereview.chromium.org/599003/diff/7001/6007#newcode321
chrome/browser/cocoa/cookies_window_controller.mm:321: // Multi-selection should
be disabled in the UI, but for sanity, double-check
On 2010/02/09 20:51:21, pink wrote:
> why can't i select multiple items? seems like i might want to erase a few
> cookies at a time w/out having to remove them all, no?

I got yelled at when I had this enabled. Something about Windows not doing it.