Remove wstring from l10n_util. Part 1....

Remove wstring from l10n_util. Part 1.

BUG=9911
TEST=no visible changes; all tests pass


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70224

[Avi (use Gerrit), 2010-12-24 00:53:12]

http://codereview.chromium.org/5990008/diff/1/app/app_base.gypi
File app/app_base.gypi (left):

http://codereview.chromium.org/5990008/diff/1/app/app_base.gypi#oldcode125
app/app_base.gypi:125: 'file_download_interface.h',
Dunno what this was but it doesn't exist.

[Evan Martin, 2010-12-24 01:00:42]

LGTM

I suggested double-checking line wrapping in a few places, but I bet some of
those don't fit

http://codereview.chromium.org/5990008/diff/1/app/l10n_util.h
File app/l10n_util.h (right):

http://codereview.chromium.org/5990008/diff/1/app/l10n_util.h#newcode28
app/l10n_util.h:28: #define CRBUG_9911_OBSOLETE_GOING_AWAY 1
Can you comment this?  (Add a link to the bug, describe why you have it, etc.)

http://codereview.chromium.org/5990008/diff/1/app/l10n_util_unittest.cc
File app/l10n_util_unittest.cc (right):

http://codereview.chromium.org/5990008/diff/1/app/l10n_util_unittest.cc#newco...
app/l10n_util_unittest.cc:60: string16 s16 =
l10n_util::GetStringFUTF16(IDS_PLACEHOLDERS_2, 20);
Can't this use a std::string as well?

http://codereview.chromium.org/5990008/diff/1/chrome/browser/character_encodi...
File chrome/browser/character_encoding.cc (right):

http://codereview.chromium.org/5990008/diff/1/chrome/browser/character_encodi...
chrome/browser/character_encoding.cc:297:
UTF8ToUTF16(GetEncodingCategoryStringByCommandId(id));
one line?

http://codereview.chromium.org/5990008/diff/1/chrome/browser/chromeos/input_m...
File chrome/browser/chromeos/input_method/input_method_util.cc (right):

http://codereview.chromium.org/5990008/diff/1/chrome/browser/chromeos/input_m...
chrome/browser/chromeos/input_method/input_method_util.cc:355:
chromeos::input_method::GetLanguageDisplayNameFromCode(s2);
one line?

http://codereview.chromium.org/5990008/diff/1/chrome/browser/language_combobo...
File chrome/browser/language_combobox_model.cc (right):

http://codereview.chromium.org/5990008/diff/1/chrome/browser/language_combobo...
chrome/browser/language_combobox_model.cc:55: LocaleData(name_native,
locale_codes[i]);
one line

http://codereview.chromium.org/5990008/diff/1/chrome/browser/ui/toolbar/encod...
File chrome/browser/ui/toolbar/encoding_menu_controller.cc (right):

http://codereview.chromium.org/5990008/diff/1/chrome/browser/ui/toolbar/encod...
chrome/browser/ui/toolbar/encoding_menu_controller.cc:105: EncodingMenuItemList*
menuItems) {
This really should be menu_items, not menuItems.
Not your prob tho

[Avi (use Gerrit), 2010-12-28 15:02:54]

None of the places you indicated allow for one-lining it. How I wish...

http://codereview.chromium.org/5990008/diff/1/app/l10n_util.h
File app/l10n_util.h (right):

http://codereview.chromium.org/5990008/diff/1/app/l10n_util.h#newcode28
app/l10n_util.h:28: #define CRBUG_9911_OBSOLETE_GOING_AWAY 1
On 2010/12/24 01:00:42, Evan Martin wrote:
> Can you comment this?  (Add a link to the bug, describe why you have it, etc.)

Done.

http://codereview.chromium.org/5990008/diff/1/app/l10n_util_unittest.cc
File app/l10n_util_unittest.cc (right):

http://codereview.chromium.org/5990008/diff/1/app/l10n_util_unittest.cc#newco...
app/l10n_util_unittest.cc:60: string16 s16 =
l10n_util::GetStringFUTF16(IDS_PLACEHOLDERS_2, 20);
On 2010/12/24 01:00:42, Evan Martin wrote:
> Can't this use a std::string as well?

No, this is a test for the int helper.

http://codereview.chromium.org/5990008/diff/1/chrome/browser/ui/toolbar/encod...
File chrome/browser/ui/toolbar/encoding_menu_controller.cc (right):

http://codereview.chromium.org/5990008/diff/1/chrome/browser/ui/toolbar/encod...
chrome/browser/ui/toolbar/encoding_menu_controller.cc:105: EncodingMenuItemList*
menuItems) {
On 2010/12/24 01:00:42, Evan Martin wrote:
> This really should be menu_items, not menuItems.
> Not your prob tho

Done anyway.