Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/browser/extensions/pack_extension_job.cc

Issue 5989012: Revert 70281 - Revert 70271 - Remove wstring from l10n_util. Part 3.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/pack_extension_job.h" 5 #include "chrome/browser/extensions/pack_extension_job.h"
6 6
7 #include "app/l10n_util.h" 7 #include "app/l10n_util.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/sys_string_conversions.h"
9 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
10 #include "base/task.h" 11 #include "base/task.h"
11 #include "chrome/browser/extensions/extension_creator.h" 12 #include "chrome/browser/extensions/extension_creator.h"
12 #include "chrome/common/chrome_constants.h" 13 #include "chrome/common/chrome_constants.h"
13 #include "grit/generated_resources.h" 14 #include "grit/generated_resources.h"
14 15
15 PackExtensionJob::PackExtensionJob(Client* client, 16 PackExtensionJob::PackExtensionJob(Client* client,
16 const FilePath& root_directory, 17 const FilePath& root_directory,
17 const FilePath& key_file) 18 const FilePath& key_file)
18 : client_(client), key_file_(key_file), asynchronous_(true) { 19 : client_(client), key_file_(key_file), asynchronous_(true) {
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 if (client_) 74 if (client_)
74 client_->OnPackSuccess(crx_file_out_, key_file_out_); 75 client_->OnPackSuccess(crx_file_out_, key_file_out_);
75 } 76 }
76 77
77 void PackExtensionJob::ReportFailureOnClientThread(const std::string& error) { 78 void PackExtensionJob::ReportFailureOnClientThread(const std::string& error) {
78 if (client_) 79 if (client_)
79 client_->OnPackFailure(error); 80 client_->OnPackFailure(error);
80 } 81 }
81 82
82 // static 83 // static
83 std::wstring PackExtensionJob::StandardSuccessMessage(const FilePath& crx_file, 84 string16 PackExtensionJob::StandardSuccessMessage(const FilePath& crx_file,
84 const FilePath& key_file) 85 const FilePath& key_file) {
85 { 86 string16 crx_file_string = WideToUTF16(crx_file.ToWStringHack());
86 // TODO(isherman): we should use string16 instead of wstring. 87 string16 key_file_string = WideToUTF16(key_file.ToWStringHack());
87 // See crbug.com/23581 and crbug.com/24672 88 if (key_file_string.empty()) {
88 std::wstring message; 89 return l10n_util::GetStringFUTF16(
89 if (key_file.empty()) {
90 return l10n_util::GetStringF(
91 IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_UPDATE, 90 IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_UPDATE,
92 crx_file.ToWStringHack()); 91 crx_file_string);
93 } else { 92 } else {
94 return l10n_util::GetStringF( 93 return l10n_util::GetStringFUTF16(
95 IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW, 94 IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW,
96 crx_file.ToWStringHack(), 95 crx_file_string,
97 key_file.ToWStringHack()); 96 key_file_string);
98 } 97 }
99 } 98 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/pack_extension_job.h ('k') | chrome/browser/importer/importer_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698