Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 5989011: Add hotlinks to individual samples in extension samples directory. (Closed)

Created:
9 years, 12 months ago by kurrik.chromium
Modified:
9 years, 7 months ago
Reviewers:
kathyw
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Add hotlinks to individual samples in extension samples directory. Update page hash when searching for samples. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70526

Patch Set 1 #

Patch Set 2 : Display tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+238 lines, -93 lines) Patch
M chrome/common/extensions/docs/js/sample_search.js View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.html View 1 46 chunks +225 lines, -90 lines 0 comments Download
M chrome/common/extensions/docs/static/samples.html View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kurrik.chromium
Hi Kathy, is this OK for individual sample hotlinks?
9 years, 12 months ago (2010-12-29 00:47:11 UTC) #1
kathyw
I like the basic behavior, but I found the words/links a bit confusing. Instead of ...
9 years, 11 months ago (2011-01-04 21:18:31 UTC) #2
kurrik.chromium
I've changed the UI to match your description. I agree that it works a bit ...
9 years, 11 months ago (2011-01-05 01:20:33 UTC) #3
kathyw
9 years, 11 months ago (2011-01-05 17:53:23 UTC) #4
LGTM

Thanks!

Powered by Google App Engine
This is Rietveld 408576698