autotest: Add network_LockedSIM test.

autotest: Add network_LockedSIM test.

This test checks that the various sim-locking operations work: changing the PIN,
locking, unlocking, disabling SIM locking, and enabling SIM locking.

BUG=chromium-os:6721
TEST=Yes

Change-Id: I4495e7702e51a5f60112c877dc30d5c27c49d331
Signed-off-by: Elly Jones <ellyjones@chromium.org>;

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=b30907d

[Jason Glasgow, 2011-01-10 20:54:17]

A few minor comments.

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
File client/site_tests/network_LockedSIM/control (right):

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
client/site_tests/network_LockedSIM/control:1: # Copyright (c) 2010 The Chromium
OS Authors. All rights reserved.
Do we start using 2011 soon?

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
File client/site_tests/network_LockedSIM/network_LockedSIM.py (right):

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
client/site_tests/network_LockedSIM/network_LockedSIM.py:30: iface =
'org.freedesktop.ModemManager.Modem.Gsm.Card'
Why not self.icard?  (For many of the methods in this class).

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
client/site_tests/network_LockedSIM/network_LockedSIM.py:53:
'/org/freedesktop/ModemManager')
Can we parameterize /org/freedesktop/ModemManager?  We might want to run this
test against cromo.

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
client/site_tests/network_LockedSIM/network_LockedSIM.py:82: self.Unlock(d,
'1111')
Can we make sure not to do this if retries < 2?  We don't want to get the SIMs
permanently locked.

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
client/site_tests/network_LockedSIM/network_LockedSIM.py:92: raise TestFailure()
If this test works for multiple devices, can we raise the TestFailure error with
the list of dbus paths (or other identifier) of the devices that failed the
test?

[Jason Glasgow, 2011-04-06 14:41:06]

Do you have time to get back to this?

[Elly Fong-Jones, 2011-04-06 17:23:19]

On 2011/04/06 14:41:06, Jason Glasgow wrote:
> Do you have time to get back to this?

Yes, today.

[Elly Fong-Jones, 2011-04-06 20:08:12]

How about now?

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
File client/site_tests/network_LockedSIM/control (right):

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
client/site_tests/network_LockedSIM/control:1: # Copyright (c) 2010 The Chromium
OS Authors. All rights reserved.
On 2011/01/10 20:54:18, Jason Glasgow wrote:
> Do we start using 2011 soon?

Done.

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
File client/site_tests/network_LockedSIM/network_LockedSIM.py (right):

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
client/site_tests/network_LockedSIM/network_LockedSIM.py:30: iface =
'org.freedesktop.ModemManager.Modem.Gsm.Card'
On 2011/01/10 20:54:18, Jason Glasgow wrote:
> Why not self.icard?  (For many of the methods in this class).

Done.

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
client/site_tests/network_LockedSIM/network_LockedSIM.py:53:
'/org/freedesktop/ModemManager')
On 2011/01/10 20:54:18, Jason Glasgow wrote:
> Can we parameterize /org/freedesktop/ModemManager?  We might want to run this
> test against cromo.

Done.

http://codereview.chromium.org/5988012/diff/1/client/site_tests/network_Locke...
client/site_tests/network_LockedSIM/network_LockedSIM.py:82: self.Unlock(d,
'1111')
On 2011/01/10 20:54:18, Jason Glasgow wrote:
> Can we make sure not to do this if retries < 2?  We don't want to get the SIMs
> permanently locked.

Done.

[Jason Glasgow, 2011-04-06 20:27:35]

http://codereview.chromium.org/5988012/diff/8001/client/site_tests/network_Lo...
File client/site_tests/network_LockedSIM/network_LockedSIM.py (right):

http://codereview.chromium.org/5988012/diff/8001/client/site_tests/network_Lo...
client/site_tests/network_LockedSIM/network_LockedSIM.py:12: class
TestFailure(Exception):
rom autotest_lib.client.common_lib import error

Then raise error.TestFail

http://git.chromium.org/gitweb/?p=autotest.git;a=blob;f=client/site_tests/net...

http://codereview.chromium.org/5988012/diff/8001/client/site_tests/network_Lo...
client/site_tests/network_LockedSIM/network_LockedSIM.py:43:
dbus_interface=iface)
self.iface, and delete line above.

http://codereview.chromium.org/5988012/diff/8001/client/site_tests/network_Lo...
client/site_tests/network_LockedSIM/network_LockedSIM.py:45: def run_once(self,
mmpath='/org/freedesktop/ModemManager'):
You should probably import mm

It provides mm.EnumerateDevices which will hit both Gobi and MM.  Then the test
will work with either set of hardware.

http://git.chromium.org/gitweb/?p=flimflam.git;a=blob;f=test/mm.py;h=61d5f602...


# Special import to define the location of the flimflam library.
from autotest_lib.client.cros import flimflam_test_path
import mm

http://codereview.chromium.org/5988012/diff/8001/client/site_tests/network_Lo...
client/site_tests/network_LockedSIM/network_LockedSIM.py:113: raise
TestFailure("%s" % failed)
raise error.TestFail('Failed for devices: %s' % ', '.join(failed))

[Elly Fong-Jones, 2011-04-07 14:05:03]

PTAL?

http://codereview.chromium.org/5988012/diff/8001/client/site_tests/network_Lo...
File client/site_tests/network_LockedSIM/network_LockedSIM.py (right):

http://codereview.chromium.org/5988012/diff/8001/client/site_tests/network_Lo...
client/site_tests/network_LockedSIM/network_LockedSIM.py:12: class
TestFailure(Exception):
On 2011/04/06 20:27:36, Jason Glasgow wrote:
> rom autotest_lib.client.common_lib import error
> 
> Then raise error.TestFail
> 
>
http://git.chromium.org/gitweb/?p=autotest.git;a=blob;f=client/site_tests/net...

Done.

http://codereview.chromium.org/5988012/diff/8001/client/site_tests/network_Lo...
client/site_tests/network_LockedSIM/network_LockedSIM.py:43:
dbus_interface=iface)
On 2011/04/06 20:27:36, Jason Glasgow wrote:
> self.iface, and delete line above.

Done.

http://codereview.chromium.org/5988012/diff/8001/client/site_tests/network_Lo...
client/site_tests/network_LockedSIM/network_LockedSIM.py:45: def run_once(self,
mmpath='/org/freedesktop/ModemManager'):
On 2011/04/06 20:27:36, Jason Glasgow wrote:
> You should probably import mm
> 
> It provides mm.EnumerateDevices which will hit both Gobi and MM.  Then the
test
> will work with either set of hardware.
> 
>
http://git.chromium.org/gitweb/?p=flimflam.git;a=blob;f=test/mm.py;h=61d5f602...
> 
> 
> # Special import to define the location of the flimflam library.
> from autotest_lib.client.cros import flimflam_test_path
> import mm

Done.

http://codereview.chromium.org/5988012/diff/8001/client/site_tests/network_Lo...
client/site_tests/network_LockedSIM/network_LockedSIM.py:113: raise
TestFailure("%s" % failed)
On 2011/04/06 20:27:36, Jason Glasgow wrote:
> raise error.TestFail('Failed for devices: %s' % ', '.join(failed))

Done.

[Jason Glasgow, 2011-04-07 14:48:15]

LGTM