focus reverse traversal was not working for TextfieldViews.

views/controls/textfield/native_textfield_wrapper.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WRAPPER_H_
 #define VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WRAPPER_H_
 #pragma once
 
 #include "base/string16.h"
 #include "gfx/native_widget_types.h"
 
 namespace gfx {
 class Insets;
 }  // namespace gfx
 
 namespace views {
 
+class KeyEvent;
 class Textfield;
 class View;
 
 // An interface implemented by an object that provides a platform-native
 // text field.
 class NativeTextfieldWrapper {
  public:
   // The Textfield calls this when it is destroyed to clean up the wrapper
   // object.
   virtual ~NativeTextfieldWrapper() {}
@@ skipping 42 matching lines @@
 
   // Returns the insets for the text field.
   virtual gfx::Insets CalculateInsets() = 0;
 
   // Updates the horizontal margins for the native text field.
   virtual void UpdateHorizontalMargins() = 0;
 
   // Updates the vertical margins for the native text field.
   virtual void UpdateVerticalMargins() = 0;
 
-  // Sets the focus to the text field.
-  virtual void SetFocus() = 0;
+  // Sets the focus to the text field. Returns fale if the wrapper

[sky, 2011/01/05 22:57:35]

fale -> false

+  // didn't take focus.
+  virtual bool SetFocus() = 0;
 
   // Retrieves the views::View that hosts the native control.
   virtual View* GetView() = 0;
 
   // Returns a handle to the underlying native view for testing.
   virtual gfx::NativeView GetTestingHandle() const = 0;
 
   // Returns whether or not an IME is composing text.
   virtual bool IsIMEComposing() const = 0;
 
+  // Following methods are to forward key/focus related events to the
+  // views wrapper so that TextfieldViews can handle key inputs without
+  // having a focus. See views::View for the description of each method.
+  virtual bool OnKeyPressed(const views::KeyEvent& e) = 0;

[sky, 2011/01/05 22:57:35]

I'm a bit worried about naming these exactly the same as the views methods.
Doesn't that lead to a weird inheritance problems?

+  virtual bool OnKeyReleased(const views::KeyEvent& e) = 0;
+  virtual void WillGainFocus() = 0;
+  virtual void DidGainFocus() = 0;
+  virtual void WillLoseFocus() = 0;
+
   // Creates an appropriate NativeTextfieldWrapper for the platform.
   static NativeTextfieldWrapper* CreateWrapper(Textfield* field);
 };
 
 }  // namespace views
 
 #endif  // VIEWS_CONTROLS_TEXTFIELD_NATIVE_TEXTFIELD_WRAPPER_H_