Implement inlining of instanceof tests on ARM.

src/arm/lithium-codegen-arm.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1319 matching lines @@
   Abort("DoClassOfTestAndBranch unimplemented.");
 }
 
 
 void LCodeGen::DoCmpMapAndBranch(LCmpMapAndBranch* instr) {
   Abort("DoCmpMapAndBranch unimplemented.");
 }
 
 
 void LCodeGen::DoInstanceOf(LInstanceOf* instr) {
-  Abort("DoInstanceOf unimplemented.");
+  // we expect object and function in registers r1 and r0.

[Søren Thygesen Gjesse, 2010/12/20 13:07:10]

Please start comment with uppercase letter.

[Karl Klose, 2010/12/21 08:56:37]

Done.

+  InstanceofStub stub(InstanceofStub::kArgsInRegisters);
+  CallCode(stub.GetCode(), RelocInfo::CODE_TARGET, instr);
+
+  Label true_value, done;
+  __ tst(r0, r0);

[Søren Thygesen Gjesse, 2010/12/20 13:07:10]

I think this can be done with conditional moves and no branching.

[Karl Klose, 2010/12/21 08:56:37]

Done.

+  __ b(eq, &true_value);
+  __ mov(r0, Operand(Factory::false_value()));
+  __ b(&done);
+  __ bind(&true_value);
+  __ mov(r0, Operand(Factory::true_value()));
+  __  bind(&done);
 }
 
 
 void LCodeGen::DoInstanceOfAndBranch(LInstanceOfAndBranch* instr) {
   Abort("DoInstanceOfAndBranch unimplemented.");
 }
 
 
 
 static Condition ComputeCompareCondition(Token::Value op) {
@@ skipping 807 matching lines @@
 
 
 void LCodeGen::DoOsrEntry(LOsrEntry* instr) {
   Abort("DoOsrEntry unimplemented.");
 }
 
 
 #undef __
 
 } }  // namespace v8::internal