Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 5987010: vboot_reference/make_dev_firmware: check write protection status before making changes (Closed)

Created:
9 years, 12 months ago by Hung-Te
Modified:
9 years, 7 months ago
Reviewers:
Randall Spangler
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

vboot_reference/make_dev_firmware: check write protection status before making changes Complete the missing part of "checking (and disabling) write protection status. This also helps to prevent erasing RW regions on system with WP enabled and then causing boot failure. BUG=chrome-os-partner:1276 TEST=(1) On CR-48 with WP enabled, run make_dev_firmware.sh without turning off WP. Result: Error message "Write protection is still enabled. Please verify that hardware write protection is disabled." (as expected) (2) Disable WP and run again. Result: firmware has been changed successfully. Change-Id: Iaf2243cb2cd3c7f83ce4f36543ea3da1e3ca55a1 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=38d3ef7

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix param checking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M scripts/image_signing/make_dev_firmware.sh View 1 2 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Hung-Te
9 years, 12 months ago (2010-12-30 10:43:07 UTC) #1
Randall Spangler
http://codereview.chromium.org/5987010/diff/1/scripts/image_signing/make_dev_firmware.sh File scripts/image_signing/make_dev_firmware.sh (right): http://codereview.chromium.org/5987010/diff/1/scripts/image_signing/make_dev_firmware.sh#newcode68 scripts/image_signing/make_dev_firmware.sh:68: if [ -n "$FLAGS_from" ]; then $FLAGS_to, right? Doesn't ...
9 years, 11 months ago (2011-01-04 21:27:44 UTC) #2
Hung-Te
http://codereview.chromium.org/5987010/diff/1/scripts/image_signing/make_dev_firmware.sh File scripts/image_signing/make_dev_firmware.sh (right): http://codereview.chromium.org/5987010/diff/1/scripts/image_signing/make_dev_firmware.sh#newcode68 scripts/image_signing/make_dev_firmware.sh:68: if [ -n "$FLAGS_from" ]; then On 2011/01/04 21:27:44, ...
9 years, 11 months ago (2011-01-05 03:43:37 UTC) #3
Randall Spangler
9 years, 11 months ago (2011-01-05 23:38:14 UTC) #4
LGTM, thanks

Powered by Google App Engine
This is Rietveld 408576698