Issue 5986020: Remove a bit of dead code from TabContentsViewWin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5986020: Remove a bit of dead code from TabContentsViewWin. (Closed)

Created:
9 years, 11 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
jcivelli

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove a bit of dead code from TabContentsViewWin. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71153

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/tab_contents/tab_contents_view_win.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jcivelli

9 years, 11 months ago (2011-01-11 17:29:33 UTC) #2

LGTM

On Tue, Jan 11, 2011 at 6:12 AM,  <finnur@chromium.org> wrote:
> Reviewers: jcivelli,
>
> Message:
> This is just dead code, right?
>
> Description:
> Remove a bit of dead code from TabContentsViewWin.
>
> BUG=None
> TEST=None
>
>
> Please review this at http://codereview.chromium.org/5986020/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/ui/views/tab_contents/tab_contents_view_win.cc
>
>
> Index: chrome/browser/ui/views/tab_contents/tab_contents_view_win.cc
> ===================================================================
> --- chrome/browser/ui/views/tab_contents/tab_contents_view_win.cc
> (revision 71019)
> +++ chrome/browser/ui/views/tab_contents/tab_contents_view_win.cc
> (working copy)
> @@ -182,9 +182,6 @@
>  }
>
>  void TabContentsViewWin::Focus() {
> -  views::FocusManager* focus_manager =
> -      views::FocusManager::GetFocusManagerForNativeView(GetNativeView());
> -
>   if (tab_contents()->interstitial_page()) {
>     tab_contents()->interstitial_page()->Focus();
>     return;
>
>
>

Expand Messages | Collapse Messages