Issue 5985010: Fix compile-problem in (currently) unused stand-alone preparser function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5985010: Fix compile-problem in (currently) unused stand-alone preparser function. (Closed)

Created:
9 years, 11 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
fschneider

CC:
v8-dev

Visibility:
Public.

Description

Fix compile-problem in (currently) unused stand-alone preparser function. Allow object initializers to define getters using string and number literals.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review comment #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -13 lines)			Patch
M	src/parser.cc	View	1	1 chunk	+11 lines, -3 lines	0 comments	Download
M	src/preparser.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	src/preparser.cc	View		2 chunks	+12 lines, -8 lines	0 comments	Download
M	src/preparser-api.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fschneider

9 years, 11 months ago (2011-01-04 12:01:38 UTC) #2

LGTM.

http://codereview.chromium.org/5985010/diff/1/src/parser.cc
File src/parser.cc (right):

http://codereview.chromium.org/5985010/diff/1/src/parser.cc#newcode2998
src/parser.cc:2998: // TODO(820): Allow NUMBER and STRING as well (and handle
array indices).
This TODO does not apply anymore?

Expand Messages | Collapse Messages