Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 5984007: Move base/debug_on_start to base/debugger and rename it to be _win since it... (Closed)

Created:
9 years, 11 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, Paweł Hajdan Jr., jam, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move base/debug_on_start to base/debugger and rename it to be _win since it only does anything on Windows. TEST=it compiles BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70362

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -156 lines) Patch
M base/base.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M base/base_switches.cc View 1 chunk +4 lines, -3 lines 0 comments Download
A + base/debug/debug_on_start_win.h View 3 chunks +13 lines, -5 lines 0 comments Download
A + base/debug/debug_on_start_win.cc View 2 chunks +9 lines, -3 lines 0 comments Download
D base/debug_on_start.h View 1 chunk +0 lines, -68 lines 0 comments Download
D base/debug_on_start.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M base/test/test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/firefox_importer_unittest_utils_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/tools/test_shell/test_shell_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
TBR
9 years, 11 months ago (2011-01-01 18:57:59 UTC) #1
jam
9 years, 11 months ago (2011-01-04 21:50:08 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698