Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 5984006: Add a dummy implementation of a new WebWidget::confirmComposition() method. (Closed)

Created:
9 years, 12 months ago by James Su
Modified:
9 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add a dummy implementation of a new WebWidget::confirmComposition() method. In order to fix https://bugs.webkit.org/show_bug.cgi?id=51693, I'm going to add following new method into WebKit::WebWidget interface: bool confirmComposition(const WebString& text) = 0; As PepperWidget implements WebKit::WebWidget interface directly, we need to add a dummy implementation of this new method into PepperWidget first to prevent chromium build from being broken. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/renderer/render_widget_fullscreen_pepper.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Su
9 years, 12 months ago (2010-12-29 23:39:48 UTC) #1
Mihai Parparita -not on Chrome
9 years, 12 months ago (2010-12-29 23:53:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698