Issue 5984001: Client-based geolocation refactoring.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5984001: Client-based geolocation refactoring. (Closed)

Created:
10 years ago by John Knottenbelt

Modified:
9 years, 7 months ago

Reviewers:
bulach

CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Client-based geolocation refactoring. Remove unnecessary double->Int64->double conversion. Conditionally Disable GeolocationPermissionContextTests.StopUpdating for client-based geolocation. BUG=59907 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69538

Patch Set 1 #

Total comments: 1

Patch Set 2 : git cl tree #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
M	chrome/browser/geolocation/geolocation_permission_context_unittest.cc	View	1	1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/renderer/geolocation_dispatcher.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Knottenbelt

Minor fixes to the geolocation refactoring code. Still behind a flag at this point.

10 years ago (2010-12-17 09:58:22 UTC) #1

bulach

10 years ago (2010-12-17 11:19:47 UTC) #2

LGTM

one suggestion below that you may want to use provided the code still compiles
under that flag (otherwise, keep as is to prevent compiling, but add a TODO to
remove the test).

http://codereview.chromium.org/5984001/diff/1/chrome/browser/geolocation/geol...
File chrome/browser/geolocation/geolocation_permission_context_unittest.cc
(right):

http://codereview.chromium.org/5984001/diff/1/chrome/browser/geolocation/geol...
chrome/browser/geolocation/geolocation_permission_context_unittest.cc:294:
TEST_F(GeolocationPermissionContextTests, StopUpdating) {
the way we normally disable tests is:

// TODO(jknotten): remove this test once we fully switch to client-based. 
#if defined(ENABLE_CLIENT_BASED_GEOLOCATION)
#define MAYBE_StopUpdating StopUpdating
#else
#define MAYBE_StopUpdating DISABLED_StopUpdating
#endif
TEST_F(GeolocationPermissionContextTests, MAYBE_StopUpdating) {

Expand Messages | Collapse Messages