Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/browser/memory_details.h

Issue 5981007: fix about:memory and memory histograms to show extensions more clearly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/memory_details.h
diff --git a/chrome/browser/memory_details.h b/chrome/browser/memory_details.h
index 2b152b66d0e6f1b32a26d893b42547372f75f3b5..6533ad423aa4d881673b21534556d4788b248bf3 100644
--- a/chrome/browser/memory_details.h
+++ b/chrome/browser/memory_details.h
@@ -31,11 +31,14 @@ struct ProcessMemoryInformation {
std::wstring product_name;
// The number of processes which this memory represents.
int num_processes;
- // A process is a diagnostics process if it is rendering
- // about:xxx information.
+ // A process is a diagnostics process if it is rendering about:memory.
+ // Mark this specially so that it can avoid counting it in its own
+ // results.
bool is_diagnostics;
// If this is a child process of Chrome, what type (i.e. plugin) it is.
ChildProcessInfo::ProcessType type;
+ // If this is a renderer process, what type it is.
+ ChildProcessInfo::RendererProcessType renderer_type;
// A collection of titles used, i.e. for a tab it'll show all the page titles.
std::vector<std::wstring> titles;
};

Powered by Google App Engine
This is Rietveld 408576698