Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/memory_details.h

Issue 5981007: fix about:memory and memory histograms to show extensions more clearly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/browser_about_handler.cc ('k') | chrome/browser/memory_details.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_MEMORY_DETAILS_H_ 5 #ifndef CHROME_BROWSER_MEMORY_DETAILS_H_
6 #define CHROME_BROWSER_MEMORY_DETAILS_H_ 6 #define CHROME_BROWSER_MEMORY_DETAILS_H_
7 #pragma once 7 #pragma once
8 8
9 #include <vector> 9 #include <vector>
10 10
(...skipping 14 matching lines...) Expand all
25 // The working set information. 25 // The working set information.
26 base::WorkingSetKBytes working_set; 26 base::WorkingSetKBytes working_set;
27 // The committed bytes. 27 // The committed bytes.
28 base::CommittedKBytes committed; 28 base::CommittedKBytes committed;
29 // The process version 29 // The process version
30 string16 version; 30 string16 version;
31 // The process product name. 31 // The process product name.
32 string16 product_name; 32 string16 product_name;
33 // The number of processes which this memory represents. 33 // The number of processes which this memory represents.
34 int num_processes; 34 int num_processes;
35 // A process is a diagnostics process if it is rendering 35 // A process is a diagnostics process if it is rendering about:memory.
36 // about:xxx information. 36 // Mark this specially so that it can avoid counting it in its own
37 // results.
37 bool is_diagnostics; 38 bool is_diagnostics;
38 // If this is a child process of Chrome, what type (i.e. plugin) it is. 39 // If this is a child process of Chrome, what type (i.e. plugin) it is.
39 ChildProcessInfo::ProcessType type; 40 ChildProcessInfo::ProcessType type;
41 // If this is a renderer process, what type it is.
42 ChildProcessInfo::RendererProcessType renderer_type;
40 // A collection of titles used, i.e. for a tab it'll show all the page titles. 43 // A collection of titles used, i.e. for a tab it'll show all the page titles.
41 std::vector<string16> titles; 44 std::vector<string16> titles;
42 }; 45 };
43 46
44 typedef std::vector<ProcessMemoryInformation> ProcessMemoryInformationList; 47 typedef std::vector<ProcessMemoryInformation> ProcessMemoryInformationList;
45 48
46 // Browser Process Information. 49 // Browser Process Information.
47 struct ProcessData { 50 struct ProcessData {
48 ProcessData(); 51 ProcessData();
49 ProcessData(const ProcessData& rhs); 52 ProcessData(const ProcessData& rhs);
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 144
142 // Returns a pointer to the ProcessData structure for Chrome. 145 // Returns a pointer to the ProcessData structure for Chrome.
143 ProcessData* ChromeBrowser(); 146 ProcessData* ChromeBrowser();
144 147
145 std::vector<ProcessData> process_data_; 148 std::vector<ProcessData> process_data_;
146 149
147 DISALLOW_COPY_AND_ASSIGN(MemoryDetails); 150 DISALLOW_COPY_AND_ASSIGN(MemoryDetails);
148 }; 151 };
149 152
150 #endif // CHROME_BROWSER_MEMORY_DETAILS_H_ 153 #endif // CHROME_BROWSER_MEMORY_DETAILS_H_
OLDNEW
« no previous file with comments | « chrome/browser/browser_about_handler.cc ('k') | chrome/browser/memory_details.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698