Issue 5981001: Use libcros to convert input method ID to keyboard overlay ID.

Issue 5981001: Use libcros to convert input method ID to keyboard overlay ID. (Closed)

Created:
10 years ago by mazda

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-reviews, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Use libcros to convert input method ID to keyboard overlay ID. BUG=chromium-os:9682 TEST='emerge-x86-generic chromeos-chrome' from source passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71159

Patch Set 1 #

Total comments: 5

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -96 lines)			Patch
M	chrome/browser/chromeos/cros/input_method_library.h	View	1 chunk	+5 lines, -0 lines	3 comments	Download
M	chrome/browser/chromeos/cros/input_method_library.cc	View	4 chunks	+93 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/dom_ui/keyboard_overlay_ui.cc	View	1 chunk	+2 lines, -2 lines	2 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util.cc	View	5 chunks	+1 line, -19 lines	0 comments	Download
M	chrome/browser/chromeos/input_method/input_method_util_unittest.cc	View	1 chunk	+0 lines, -74 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mazda

I will add tools/cros.DEPS/DEPS to this CL after I check in the libcros CLs.

10 years ago (2010-12-17 09:40:15 UTC) #2

satorux1

LGTM http://codereview.chromium.org/5981001/diff/1/chrome/browser/chromeos/cros/input_method_library.h File chrome/browser/chromeos/cros/input_method_library.h (right): http://codereview.chromium.org/5981001/diff/1/chrome/browser/chromeos/cros/input_method_library.h#newcode107 chrome/browser/chromeos/cros/input_method_library.h:107: const std::string& input_method_id) = 0; You can make ...

9 years, 11 months ago (2011-01-05 03:42:29 UTC) #3

mazda

Please take another look. http://codereview.chromium.org/5981001/diff/1/chrome/browser/chromeos/cros/input_method_library.h File chrome/browser/chromeos/cros/input_method_library.h (right): http://codereview.chromium.org/5981001/diff/1/chrome/browser/chromeos/cros/input_method_library.h#newcode107 chrome/browser/chromeos/cros/input_method_library.h:107: const std::string& input_method_id) = 0; ...

9 years, 11 months ago (2011-01-05 11:29:44 UTC) #4

satorux1

9 years, 11 months ago (2011-01-06 04:39:19 UTC) #5

LGTM

http://codereview.chromium.org/5981001/diff/1/chrome/browser/chromeos/cros/in...
File chrome/browser/chromeos/cros/input_method_library.h (right):

http://codereview.chromium.org/5981001/diff/1/chrome/browser/chromeos/cros/in...
chrome/browser/chromeos/cros/input_method_library.h:107: const std::string&
input_method_id) = 0;
On 2011/01/05 11:29:44, mazda wrote:
> On 2011/01/05 03:42:29, satorux1 wrote:
> > You can make it a const function as this function does not change any state.
> Since EnsureLoadedAndStarted, which is used for the implementation, is
> non-const, it is difficult to change this function to const function.
> Do you have any ideas?

Then, it's fine to be non-const. Sorry about the bad suggestion.

Expand Messages | Collapse Messages