Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 598075: Removal Of NPObjectProxy ClassId (Closed)

Created:
10 years, 10 months ago by Jeff Timanus
Modified:
9 years, 7 months ago
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

CL removing unnecessary public exposure of the NPObjectProxy COM class. This class is only used internally to the o3d host control, and can be instantiated without a class-id, and the associated machinery. BUG=None TEST=None Submitted: http://codereview.chromium.org/593083

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -84 lines) Patch
M installer/win/o3d.wxs View 1 chunk +0 lines, -29 lines 0 comments Download
M plugin/npapi_host_control/win/np_browser_proxy.cc View 1 chunk +6 lines, -1 line 0 comments Download
M plugin/npapi_host_control/win/np_object_proxy.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
D plugin/npapi_host_control/win/np_object_proxy.rgs View 1 chunk +0 lines, -37 lines 0 comments Download
M plugin/npapi_host_control/win/npapi_host_control.idl View 1 chunk +0 lines, -8 lines 0 comments Download
M plugin/npapi_host_control/win/npapi_host_control.rc View 1 chunk +0 lines, -1 line 0 comments Download
M plugin/npapi_host_control/win/resource.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jeff Timanus
Hi Tristan, Please review this CL when you have a moment. There isn't much magic ...
10 years, 10 months ago (2010-02-11 20:27:31 UTC) #1
Jeff Timanus
Posting again, now that my @chromium account is a member of o3d-review.
10 years, 10 months ago (2010-02-11 22:04:42 UTC) #2
Tristan Schmelcher 2
LGTM Thanks a lot for doing this. Will make bundling much easier. http://codereview.chromium.org/598075/diff/1/2 File plugin/npapi_host_control/win/np_object_proxy.h ...
10 years, 10 months ago (2010-02-12 19:29:25 UTC) #3
Jeff Timanus
10 years, 10 months ago (2010-02-12 20:32:07 UTC) #4
http://codereview.chromium.org/598075/diff/1/2
File plugin/npapi_host_control/win/np_object_proxy.h (right):

http://codereview.chromium.org/598075/diff/1/2#newcode125
plugin/npapi_host_control/win/np_object_proxy.h:125:
//OBJECT_ENTRY_AUTO(__uuidof(NPObjectProxy), NPObjectProxy);
On 2010/02/12 19:29:26, tschmelcher wrote:
> Might as well just delete this line and the comment.

Thanks for catching that.
Done.

Powered by Google App Engine
This is Rietveld 408576698